fix, chore: Removing some dead code (now is the perfect time: selenium 4.9.0. is more strict on being w3c) #16665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rkConnectionEnabled. I have checked and we do not use it anymore it in our tests (We used back then for AirPlane mode and so, but not anymore). So we can delete the whole code now I think.
czp13
changed the title
czp13
changed the title
czp13
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
czp13
added a commit
that referenced
this pull request
Apr 22, 2023
Artur-
approved these changes
Apr 22, 2023
mcollovati
added a commit
that referenced
this pull request
Apr 24, 2023
This reverts commit 1779aed.
ZheSun88
pushed a commit
that referenced
this pull request
Aug 14, 2023
Selenium most up-to-date update is not letting anymore to setup networkConnectionEnabled. I have checked and we do not use it anymore it in our tests (We used back then for AirPlane mode and so, but not anymore). So we can delete the whole code now I think.
ZheSun88
added a commit
that referenced
this pull request
Aug 16, 2023
* chore: update TB to 9.0.7 * chore: Removing some dead code (#16665) Selenium most up-to-date update is not letting anymore to setup networkConnectionEnabled. I have checked and we do not use it anymore it in our tests (We used back then for AirPlane mode and so, but not anymore). So we can delete the whole code now I think. --------- Co-authored-by: czp13 <61667986+czp13@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
chromeOptions.setCapability("networkConnectionEnabled", true);was deprecated, and now it was removed from Selenium, but we used it in our chromeOptions, which caused an exception now as we tried to update to the latest selenium version.This was needed to be able to do a
setConnectionType()in Chrome.BUT:
I have checked and
setConnectionType()is not used anymore, so I am removing code parts that are not w3 compliant anymore, it was used in PWA-related IT tests back then, but not now. In that case, no point to block us from using the latest/safest selenium versions. Did we use it back then for AirPlane mode and other modes potentially? So we can delete the whole related code now, I hope.More info:
MobileEmuliation seems is w3c compatible🤞:
Fixes # (issue):
I need this to unblock this:
Type of change
Checklist
Additional for
Featuretype of change