Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: rename dev.hilla to com.vaadin.hilla #18337

Merged
merged 3 commits into from
Dec 22, 2023
Merged

Conversation

cromoteca
Copy link
Contributor

Description

Hilla is undergoing a package renaming that affects some files in Flow. This PR makes the necessary changes.

Part of vaadin/hilla#1904

Type of change

  • Bugfix
  • Feature

Copy link

github-actions bot commented Dec 20, 2023

Test Results

1 045 files  ±  0  1 045 suites  ±0   1h 15m 10s ⏱️ + 4m 11s
6 744 tests ±  0  6 699 ✔️ ±  0  45 💤 ±0  0 ±0 
7 046 runs  +14  6 990 ✔️ +14  56 💤 ±0  0 ±0 

Results for commit 4df0469. ± Comparison against base commit 05e31ff.

♻️ This comment has been updated with latest results.

Copy link

sonarcloud bot commented Dec 20, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@cromoteca cromoteca changed the title feat: rename dev.hilla to com.vaadin.hilla feat!: rename dev.hilla to com.vaadin.hilla Dec 20, 2023
@cromoteca cromoteca changed the title feat!: rename dev.hilla to com.vaadin.hilla feat: rename dev.hilla to com.vaadin.hilla Dec 20, 2023
@mcollovati mcollovati added the Contribution PRs coming from the community or external to the team label Dec 21, 2023
@tarekoraby
Copy link
Contributor

tarekoraby commented Dec 21, 2023

Is the 0.0.1 label the right one? This should land in Flow 24.4.

@mcollovati
Copy link
Collaborator

Is the 0.0.1 label the right one? This should land in Flow 24.4.

Label is applied automatically (https://teamcity.vaadin.com/viewLog.html?buildId=214295&buildTypeId=Flow_FlowPullRequestsValidationSet_ApiDiffLabeling) and the PR does not introduce changes that may give a different label.

Anyway, flow main is currently 24.4-SNAPSHOT so 0.0.1 makes sense to me

@mshabarov mshabarov merged commit c827658 into main Dec 22, 2023
40 of 42 checks passed
@mshabarov mshabarov deleted the feat/hilla/rename-package branch December 22, 2023 06:52
@mshabarov mshabarov changed the title feat: rename dev.hilla to com.vaadin.hilla feat!: rename dev.hilla to com.vaadin.hilla Dec 22, 2023
@tarekoraby
Copy link
Contributor

I was just worried that 0.0.1 implies that this will be picked up in a 24.3 patch release.

@caalador
Copy link
Contributor

caalador commented Dec 22, 2023

the label just shows what the target should be by minimum so by the rules this needs a patch release where as 0.1.0 would mean that it needs a minor bump and 1.0.0 needs a major bump.
It doesn't dictate where it is going to be added to.

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.4.0.alpha1 and is also targeting the upcoming stable 24.4.0 version.

rodolforfq pushed a commit that referenced this pull request Feb 8, 2024
* Rename dev.hilla to com.vaadin.hilla

* formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants