Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package naming changes #1904

Closed
platosha opened this issue Dec 19, 2023 · 5 comments · Fixed by #1943
Closed

Package naming changes #1904

platosha opened this issue Dec 19, 2023 · 5 comments · Fixed by #1943

Comments

@platosha
Copy link
Contributor

platosha commented Dec 19, 2023

For Java artifacts, the package names and Maven groupIds should be com.vaadin.hilla (instead of dev.hilla). Artifact names stay the same.

For npm packages, all packages that require using Hilla should be prefixed with @vaadin/hilla- instead of @hilla/, with few exceptions:

  • @hilla/frontend@vaadin/hilla-core
  • @hilla/form@vaadin/hilla-lit-form
  • @hilla/react-components@vaadin/react-components (out of scope for this issue)
  • Consider simplifying the naming for the generator-typescript- packages, maybe the typescript- part could be removed
@tarekoraby
Copy link
Contributor

tarekoraby commented Dec 21, 2023

Perhaps hilla Java artifact should be renamed to hilla-lit.

@taefi
Copy link
Contributor

taefi commented Jan 5, 2024

Perhaps hilla Java artifact should be renamed to hilla-lit.

In that case, we may also consider renaming hilla-spring-boot-starter to hilla-lit-spring-boot-starter to align it with the hilla-lit and hilla-react-spring-boot-starter. WDYT @platosha?

@tarekoraby
Copy link
Contributor

Yes, let's do that.

@taefi
Copy link
Contributor

taefi commented Jan 5, 2024

Apart from simplifying generator-typescript-xxx to generator-xxx, renaming the npm package name in package.json from @hilla/generator-xxx to @vaadin/generator-xxx sounds a bit weird, though, it doesn't affect users that much. As I personally prefer having scopes in naming, I suggest adding the hilla- to have the npm package name as @vaadin/hilla-generator-xxx. Any counter arguments?

taefi added a commit that referenced this issue Jan 5, 2024
taefi added a commit that referenced this issue Jan 11, 2024
* feat!: rename npm packages

Fixes #1904

---------

Co-authored-by: Vlad Rindevich <vladrin@vaadin.com>
Co-authored-by: Luciano Vernaschi <luciano@vaadin.com>
cromoteca added a commit that referenced this issue Jan 11, 2024
* feat!: rename npm packages

Fixes #1904

---------

Co-authored-by: Vlad Rindevich <vladrin@vaadin.com>
Co-authored-by: Luciano Vernaschi <luciano@vaadin.com>
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Hilla 24.4.0.alpha1 and is also targeting the upcoming stable 24.4.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants