fix: use Thread context ClassLoader for loading I18n ResourceBundle #19791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
platosha
commented
Aug 15, 2024
platosha
commented
- fix: use Thread context ClassLoader for loading I18n ResourceBundle
- fix: make sure DefaultInstantiator also uses thread context ClassLoader for menu and i18n resources
ResourceBundle caches resources internally, this affects translation resources for the I18n feature. However, after a hot reload of a SpringBoot application in dev mode, up-to-date translations are expected in the output. With this change, a RestartClassLoader is used in SpringBoot applications for loading translation ResourceBundle, so that the translation bundles are reloaded on hot reload. Fixes vaadin/hilla#2554
…er for menu and i18n resources
platosha
force-pushed
the
fix/ap/hilla-2554
branch
from
67a9aaf
to
4a9a309
Compare
platosha
changed the title
caalador
reviewed
Aug 23, 2024
| @@ -30,18 +33,34 @@ | |||
| import com.vaadin.flow.server.InvalidMenuAccessControlException; | |||
| import com.vaadin.flow.server.VaadinContext; | |||
| import com.vaadin.flow.server.VaadinService; | |||
| import org.mockito.invocation.InvocationOnMock; | |||
|
|
|||
| import static org.junit.Assert.assertThrows; | |||
|
|
|||
| public class DefaultInstantiatorMenuAccessControlTest { | |||
There was a problem hiding this comment.
This should perhaps be marked with @NotThreadSafe as we use a set current in the test
caalador
approved these changes
Aug 23, 2024
|
vaadin-bot
pushed a commit
that referenced
this pull request
Aug 23, 2024
…19791) ResourceBundle caches resources internally, this affects translation resources for the I18n feature. However, after a hot reload of a SpringBoot application in dev mode, up-to-date translations are expected in the output. With this change, a RestartClassLoader is used in SpringBoot applications for loading translation ResourceBundle, so that the translation bundles are reloaded on hot reload. Fixes vaadin/hilla#2554
vaadin-bot
added a commit
that referenced
this pull request
Aug 23, 2024
…19791) (#19821) ResourceBundle caches resources internally, this affects translation resources for the I18n feature. However, after a hot reload of a SpringBoot application in dev mode, up-to-date translations are expected in the output. With this change, a RestartClassLoader is used in SpringBoot applications for loading translation ResourceBundle, so that the translation bundles are reloaded on hot reload. Fixes vaadin/hilla#2554 Co-authored-by: Anton Platonov <anton@vaadin.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.