Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use Thread context ClassLoader for loading I18n ResourceBundle #19791

Merged
merged 11 commits into from
Aug 23, 2024
Merged

fix: use Thread context ClassLoader for loading I18n ResourceBundle #19791

merged 11 commits into from
Aug 23, 2024

Commits on Aug 21, 2024

  1. fix: use Thread context ClassLoader for loading I18n ResourceBundle 

    ResourceBundle caches resources internally, this affects translation resources for the I18n feature. However, after a hot reload of a SpringBoot application in dev mode, up-to-date translations are expected in the output.

With this change, a RestartClassLoader is used in SpringBoot applications for loading translation ResourceBundle, so that the translation bundles are reloaded on hot reload.

Fixes vaadin/hilla#2554
    @platosha
    platosha committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    4bcd731 View commit details
    Browse the repository at this point in the history

  2. fix: make sure DefaultInstantiator also uses thread context ClassLoad… 

    …er for menu and i18n resources
    @platosha
    platosha committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    ef97f92 View commit details
    Browse the repository at this point in the history

  3. test(vaadin-spring): make sure DefaultI18NProviderFactory uses contex… 

    …t classLoader
    @platosha
    platosha committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    4a9a309 View commit details
    Browse the repository at this point in the history

  4. test(vaadin-spring): cleanup and fix i18N test interference

    @platosha
    platosha committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    da67716 View commit details
    Browse the repository at this point in the history

  5. test(vaadin-spring): more i18n test interference fixes

    @platosha
    platosha committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    868435a View commit details
    Browse the repository at this point in the history

  6. test(vaadin-spring): i18n test inteference different tactic

    @platosha
    platosha committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    b71ca94 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. chore: formatting

    @platosha
    platosha committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    9a7375f View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. Merge branch 'main' into fix/ap/hilla-2554

    @platosha
    platosha authored Aug 23, 2024
    Configuration menu
    Copy the full SHA
    00c9119 View commit details
    Browse the repository at this point in the history

  2. add NotThreadSafe to test

    @caalador
    caalador committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    b4626db View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into fix/ap/hilla-2554

    @caalador
    caalador authored Aug 23, 2024
    Configuration menu
    Copy the full SHA
    791a02c View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into fix/ap/hilla-2554

    @caalador
    caalador authored Aug 23, 2024
    Configuration menu
    Copy the full SHA
    1a46e92 View commit details
    Browse the repository at this point in the history