refactor(react-signals): simplify the implementation #2657
Conversation
# Conflicts: # package-lock.json # packages/ts/react-signals/src/EventChannel.ts # packages/ts/react-signals/src/Signals.ts
…reateSignalChannel`
… to support multi-subscription
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2657 +/- ##
==========================================
- Coverage 92.17% 92.16% -0.02%
==========================================
Files 78 76 -2
Lines 2454 2449 -5
Branches 634 636 +2
==========================================
- Hits 2262 2257 -5
+ Misses 145 144 -1
- Partials 47 48 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Apart from some points I didn't fully understand (mentioned down there), In general, I like the way things got simpler. However, there are things I don't like:
In the currently existing implementation (main branch), the signal was isolated, while now it know about an external thing called channel and how it connects to the server and etc. SignalChannel also knows about the signal (ValueSignal), so now they are very coupled together.
There was a problem hiding this comment.
The followings seems to be missing:
- Tests for
SubscriptionManager'scancelandsubscriptionpublic methods. - Tests for
FullStackSignal'spending,error,updatingpublic methods.
And, a misbehaviour is now happening at runtime, that is an update is sent to the server before even any call for subscription is made to the server. It is trying to set a null value on server-side instance, but since no subscription exists yet for the targeted signal instance, it simply fails with IllegalStateException causing unnecessary buzz in the console (both on client and on server).
Other details are commented on the code:
|
No description provided.