Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add automatic unsubscription from the signal instance #2656

Closed
wants to merge 4 commits into from

Conversation

taefi
Copy link
Contributor

@taefi taefi commented Aug 14, 2024

Description

This also postpones subscribing to a signal
instance until the client-side signal is
actually being subscribed to (rendered).

Fixes #2621

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

This also postpones subscribing to a signal
instance until the client-side signal is
actually being subscribed to (rendered).

Fixes #2621
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 91.89189% with 3 lines in your changes missing coverage. Please review.

Project coverage is 92.15%. Comparing base (0ebdc3e) to head (ba6e41c).
Report is 4 commits behind head on main.

Files Patch % Lines
packages/ts/react-signals/src/EventChannel.ts 86.95% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2656      +/-   ##
==========================================
- Coverage   92.17%   92.15%   -0.02%     
==========================================
  Files          78       78              
  Lines        2454     2486      +32     
  Branches      634      639       +5     
==========================================
+ Hits         2262     2291      +29     
- Misses        145      148       +3     
  Partials       47       47              
Flag Coverage Δ
unittests 92.15% <91.89%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This enables removing the active mappings between
the server-side signal instance and client signals
with no subscription from the view.
Copy link

sonarcloud bot commented Aug 15, 2024

@taefi
Copy link
Contributor Author

taefi commented Aug 20, 2024

Closed due to the refactoring done in #2657, and in favor of #2663

@taefi taefi closed this Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Full-stack Signals] add automatic unsubscription from the signal instance
1 participant