Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add automatic subscribe/unsubscribe to signals #2663

Merged
merged 7 commits into from
Aug 20, 2024

Conversation

taefi
Copy link
Contributor

@taefi taefi commented Aug 19, 2024

Description

Fixes #2621

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.21%. Comparing base (0539d03) to head (34f3e96).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2663      +/-   ##
==========================================
+ Coverage   92.16%   92.21%   +0.05%     
==========================================
  Files          76       76              
  Lines        2449     2466      +17     
  Branches      636      639       +3     
==========================================
+ Hits         2257     2274      +17     
  Misses        144      144              
  Partials       48       48              
Flag Coverage Δ
unittests 92.21% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@taefi taefi marked this pull request as ready for review August 20, 2024 08:39
@taefi taefi requested a review from Lodin August 20, 2024 12:20
Copy link

sonarcloud bot commented Aug 20, 2024

@Lodin Lodin merged commit 5a0dcc4 into main Aug 20, 2024
15 checks passed
@Lodin Lodin deleted the taefi/new-signals-auto-unsubscribe branch August 20, 2024 12:50
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Hilla 24.5.0.alpha10 and is also targeting the upcoming stable 24.5.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Full-stack Signals] add automatic unsubscription from the signal instance
3 participants