chore: fix compilation after textfield renaming #1600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshabarov
reviewed
Feb 1, 2023
| @@ -24,7 +24,7 @@ | |||
| */ | |||
| @Tests({ TextField.class, PasswordField.class, EmailField.class, | |||
| BigDecimalField.class }) | |||
| public class TextFieldTester<T extends InternalFieldBase<T, V>, V> | |||
| public class TextFieldTester<T extends TextFieldBase<T, V>, V> | |||
There was a problem hiding this comment.
interesting.. locally it builds for me.. aww.
There was a problem hiding this comment.
oh, it failed on other part.. for this line, it doesn't need extra class import
/opt/agent/work/ef9ade89d4c3cefd/vaadin-testbench-unit-junit5/src/test/java/com/vaadin/testbench/unit/ComponentQueryTest.java:[28,43] cannot find symbol
[11:30:05] [Step 4/5] [ERROR] symbol: class InternalFieldBase
[11:30:05] [Step 4/5] [ERROR] location: package com.vaadin.flow.component.textfield
[11:30:05] [Step 4/5] [ERROR] /opt/agent/work/ef9ade89d4c3cefd/vaadin-testbench-unit-junit5/src/test/java/com/vaadin/testbench/unit/ComponentQueryTest.java:[496,19] cannot find symbol
[11:30:05] [Step 4/5] [ERROR] symbol: class InternalFieldBase
[11:30:05] [Step 4/5] [ERROR] location: class com.vaadin.testbench.unit.ComponentQueryTest
[11:30:05] [Step 4/5] [ERROR] -> [Help 1]
ZheSun88
force-pushed
the
fix-compilation
branch
from
e396984 to
42e51b7
Compare
|
there is another usage for the old |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related changes vaadin/flow-components@8b6c3f1