Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix compilation after textfield renaming #1600

Merged
merged 1 commit into from
Feb 1, 2023
Merged

chore: fix compilation after textfield renaming #1600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions vaadin-testbench-unit-junit5/src/test/java/com/vaadin/testbench/unit/ComponentQueryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@
import com.vaadin.flow.component.button.Button;
import com.vaadin.flow.component.html.Div;
import com.vaadin.flow.component.textfield.IntegerField;
import com.vaadin.flow.component.textfield.InternalFieldBase;
import com.vaadin.flow.component.textfield.TextField;
import com.vaadin.flow.component.textfield.TextFieldBase;
import com.vaadin.flow.dom.Element;
import com.vaadin.testbench.unit.ComponentTesterTest.Span;
import com.vaadin.testbench.unit.ElementConditionsTest.TextComponent;
Expand Down Expand Up @@ -493,7 +493,7 @@ void withValue_expectedNull_findsAllComponent() {
rootElement.appendChild(otherField.getElement());

Assertions.assertIterableEquals(List.of(targetField, otherField),
$(InternalFieldBase.class).withValue(null).all());
$(TextFieldBase.class).withValue(null).all());
}

@Test
Expand Down
2 changes: 1 addition & 1 deletion ...tbench-unit-shared/src/main/java/com/vaadin/flow/component/textfield/TextFieldTester.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
*/
@Tests({ TextField.class, PasswordField.class, EmailField.class,
BigDecimalField.class })
public class TextFieldTester<T extends InternalFieldBase<T, V>, V>
public class TextFieldTester<T extends TextFieldBase<T, V>, V>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

class import is missing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting.. locally it builds for me.. aww.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, it failed on other part.. for this line, it doesn't need extra class import

/opt/agent/work/ef9ade89d4c3cefd/vaadin-testbench-unit-junit5/src/test/java/com/vaadin/testbench/unit/ComponentQueryTest.java:[28,43] cannot find symbol
[11:30:05]	[Step 4/5] [ERROR]   symbol:   class InternalFieldBase
[11:30:05]	[Step 4/5] [ERROR]   location: package com.vaadin.flow.component.textfield
[11:30:05]	[Step 4/5] [ERROR] /opt/agent/work/ef9ade89d4c3cefd/vaadin-testbench-unit-junit5/src/test/java/com/vaadin/testbench/unit/ComponentQueryTest.java:[496,19] cannot find symbol
[11:30:05]	[Step 4/5] [ERROR]   symbol:   class InternalFieldBase
[11:30:05]	[Step 4/5] [ERROR]   location: class com.vaadin.testbench.unit.ComponentQueryTest
[11:30:05]	[Step 4/5] [ERROR] -> [Help 1]

extends ComponentTester<T> {

/**
Expand Down