Skip to content

Commit

Permalink
Do not dispatch axis event if axis data is not available (#337)
Browse files Browse the repository at this point in the history
Axis afterSetExtremes is meaningless if axis is not defined.
Also helps prevent flow#3102
Fixes CHARTS-778
  • Loading branch information
alvarezguille committed Apr 30, 2018
1 parent 13d8137 commit 2965b47
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 0 deletions.
12 changes: 12 additions & 0 deletions test/element-events-test.html
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,18 @@
timelineChart.addEventListener('yaxes-extremes-set', setExtremesListener);
timelineChart.configuration.yAxis[0].setExtremes(minExtreme, maxExtreme);
});

it('should not trigger axis event if axis is hidden by action', done => {
const axisResizeSpy = sinon.spy();
chart.addEventListener('yaxes-extremes-set', axisResizeSpy);
chart.configuration.series[0].setVisible(false);
setTimeout(() => {
expect(axisResizeSpy.called).to.be.false;
chart.removeEventListener('chart-redraw', axisResizeSpy);
chart.configuration.series[0].setVisible(true);
done();
});
});
});
</script>
</body>
5 changes: 5 additions & 0 deletions vaadin-chart.html
Original file line number Diff line number Diff line change
Expand Up @@ -852,6 +852,11 @@
}
};

if (event.type === 'afterSetExtremes') {
if (!event.min || !event.max) {
return;
}
}
// Workaround for vaadin-charts-flow because of https://github.com/vaadin/flow/issues/3102
if (event.type === 'selection') {
if (event.xAxis && event.xAxis[0]) {
Expand Down

0 comments on commit 2965b47

Please sign in to comment.