Do not dispatch axis event if axis data is not available #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Axis afterSetExtremes is meaningless if axis is not defined. Also helps prevent flow#3102 Fixes CHARTS-778
|
Reviewed 1 of 2 files at r1, 1 of 1 files at r2. Comments from Reviewable |
alvarezguille
added a commit
that referenced
this pull request
Apr 30, 2018
Axis afterSetExtremes is meaningless if axis is not defined. Also helps prevent flow#3102 Fixes CHARTS-778 Cherry-pick from #337
DiegoCardoso
pushed a commit
that referenced
this pull request
May 3, 2018
* Do not dispatch axis event if axis data is not available Axis afterSetExtremes is meaningless if axis is not defined. Also helps prevent flow#3102 Fixes CHARTS-778 Cherry-pick from #337 * Fix conditional for false positives (min/max = 0)
tomivirkki
added a commit
that referenced
this pull request
Jun 6, 2018
* Do not dispatch axis event if axis data is not available (#338) * Do not dispatch axis event if axis data is not available Axis afterSetExtremes is meaningless if axis is not defined. Also helps prevent flow#3102 Fixes CHARTS-778 Cherry-pick from #337 * Fix conditional for false positives (min/max = 0) * Adding description file for Vaadin Directory (#336) * Pin shadycss to ~1.1.0 (#342) See more at Polymer/polymer#5221 * Revert "Pin shadycss to ~1.1.0 (#342)" (#345) * Revert "Pin shadycss to ~1.1.0 (#342)" This reverts commit 2e8e260. * Support stack and stacking properties for series (#349) * Support stack and stacking properties * CHARTS-753: Series additional options (#350) * Chart labels fix for arrays in which the first element is a string (#352) * Set the first element of array as name and leave x unset if now user-supplied mapper finds a name for the point * Tests for other chart label scenarios * Simplify label assignment. Sort testcase as expected by Highcharts. https://www.highcharts.com/errors/15 * Support chart3d attribute (#351) * Support chart3d attribute - Add default values for alpha, beta and depth for options3d - Add the information at property documentation * Add bar as supported type to chart3d doc * 6.1.0-alpha6 (#353) * Change importing order/structure and definition of the classes * Update demos * Move IE11 and iOS to cron build (#358) * Empty-text property on vaadin-chart (#357) * Empty-text property on vaadin-chart * Should display empty-text when all data-containing series are removed from existing charts * Add neck width attribute to series (#359) * Add neckWidth property Add test for the new property * Add observer to neckWidth property Add test for changing neckWidth value Add doc * Highcharts 6 compatibility * Fix 3D by performing 3D setup after next render after initialization completes. Add observers after initialization. * Check global scope for Highcharts * Test fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Axis afterSetExtremes is meaningless if axis is not defined.
Also helps prevent flow#3102
Fixes CHARTS-778
This change is