-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove iron-icon import from vaadin-icons.html #72
Comments
The same should be done for https://github.com/vaadin/vaadin-lumo-styles/blob/master/icons.html#L3, right? |
Yes, I would prefer us having these aligned. |
I guess we could extract the actual iconset definition from e.g. If we go with the name <link rel="import" href="../iron-iconset-svg/iron-iconset-svg.html">
<iron-iconset-svg name="vaadin" size="16">
...
</iron-iconset-svg> And then <link rel="import" href="../iron-icon/iron-icon.html">
<link rel="import" href="iconset.html"> (plus some comments that the file now has) Any comments @jouni @web-padawan? And then similar change in |
Split iconset definition from vaadin-icons.html into new iconset.html (which is then imported in vaadin-icons.html). This makes it so importing vaadin-icons.html works as before (and includes import of iron-icon) to maintain backwards compatibility, but now the developer also has the option to import the iconset without the iron-icon dependency by importing iconset.html directly. This is useful in some cases like when doing lazy asynchronous imports. Fixes #72
Split iconset definition from vaadin-icons.html into new iconset.html (which is then imported in vaadin-icons.html). This makes it so importing vaadin-icons.html works as before (and includes import of iron-icon) to maintain backwards compatibility, but now the developer also has the option to import the iconset without the iron-icon dependency by importing iconset.html directly. This is useful in some cases like when doing lazy asynchronous imports. Fixes #72
vaadin/vaadin-icons#76 Split iconset definition from vaadin-icons.html into new iconset.html (which is then imported in vaadin-icons.html). This makes it so importing vaadin-icons.html works as before (and includes import of iron-icon) to maintain backwards compatibility, but now the developer also has the option to import the iconset without the iron-icon dependency by importing iconset.html directly. This is useful in some cases like when doing lazy asynchronous imports. Fixes: vaadin/vaadin-icons#72
Motivation based on the internal discussion:
We can still keep
iron-icon
as a dependency for backwards compatibility, and even have a separate file importing it as well, in order to avoid breaking change.The text was updated successfully, but these errors were encountered: