Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide alternate import for Lumo icons which doesn't import iron-icon #65

Closed
Haprog opened this issue Mar 15, 2019 · 1 comment
Closed

Provide alternate import for Lumo icons which doesn't import iron-icon #65

Haprog opened this issue Mar 15, 2019 · 1 comment
Assignees
@Haprog

Comments

@Haprog
Copy link
Contributor

Haprog commented Mar 15, 2019

This is useful in some cases like when doing lazy asynchronous imports (like vaadin.com is doing).

Let's make this aligned with vaadin-icons. See: vaadin/vaadin-icons#72
@Haprog
Copy link
Contributor Author

Haprog commented Mar 15, 2019

Note: This is not needed for vaadin-material-styles since that only provides font-icons but no iron-iconset.

Haprog added a commit that referenced this issue Mar 15, 2019
@Haprog
feat: provide iconset import without iron-icon dependency
7b82e31 
Split iconset definition from icons.html into new iconset.html (which is then imported in icons.html).
This makes it so importing icons.html works as before (and includes import of iron-icon) to maintain backwards compatibility, but now the developer also has the option to import the iconset without the iron-icon dependency by importing iconset.html directly. This is useful in some cases like when doing lazy asynchronous imports.

Fixes #65
@Haprog Haprog mentioned this issue Mar 15, 2019
Merged
@Haprog Haprog self-assigned this Mar 15, 2019
web-padawan pushed a commit that referenced this issue Mar 19, 2019
@Haprog @web-padawan
feat: provide iconset import without iron-icon dependency (#67)
842117e 
Split iconset definition from icons.html into new iconset.html (which is then imported in icons.html).
This makes it so importing icons.html works as before (and includes import of iron-icon) to maintain backwards compatibility, but now the developer also has the option to import the iconset without the iron-icon dependency by importing iconset.html directly. This is useful in some cases like when doing lazy asynchronous imports.

Fixes #65
web-padawan pushed a commit to vaadin/web-components that referenced this issue Mar 3, 2021
@Haprog @web-padawan
feat: provide iconset import without iron-icon dependency
9397797 
vaadin/vaadin-lumo-styles#67

Split iconset definition from icons.html into new iconset.html (which is then imported in icons.html).
This makes it so importing icons.html works as before (and includes import of iron-icon) to maintain backwards compatibility, but now the developer also has the option to import the iconset without the iron-icon dependency by importing iconset.html directly. This is useful in some cases like when doing lazy asynchronous imports.

Fixes: vaadin/vaadin-lumo-styles#65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Haprog Haprog

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Haprog @web-padawan