Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.6.0: gulp icons crashes, Gulp 3 incompatible with Node 12 #85

Closed
lkraav opened this issue Apr 12, 2020 · 3 comments · Fixed by #88
Closed

1.6.0: gulp icons crashes, Gulp 3 incompatible with Node 12 #85

lkraav opened this issue Apr 12, 2020 · 3 comments · Fixed by #88

Comments

@lkraav
Copy link
Contributor

lkraav commented Apr 12, 2020 •
edited
Loading 

leho@papaya vaadin-lumo-styles $ [git:master] npx gulp icons
fs.js:35
} = primordials;
    ^

ReferenceError: primordials is not defined
    at fs.js:35:5
    at req_ (/home/leho/Documents/web-components/vaadin-lumo-styles/node_modules/natives/index.js:143:24)
    at Object.req [as require] (/home/leho/Documents/web-components/vaadin-lumo-styles/node_modules/natives/index.js:55:10)
    at Object.<anonymous> (/home/leho/Documents/web-components/vaadin-lumo-styles/node_modules/graceful-fs/fs.js:1:37)
    at Module._compile (internal/modules/cjs/loader.js:1158:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1178:10)
    at Module.load (internal/modules/cjs/loader.js:1002:32)
    at Function.Module._load (internal/modules/cjs/loader.js:901:14)
    at Module.require (internal/modules/cjs/loader.js:1044:19)
    at require (internal/modules/cjs/helpers.js:77:18)

See
@lkraav
Copy link
Contributor Author

lkraav commented Apr 12, 2020 •
edited
Loading

After npm install gulp@^4, I think gulp icons needs additional help to work:

$ [git:master+] npx gulp icons
assert.js:385
    throw err;
    ^

AssertionError [ERR_ASSERTION]: Task function must be specified
    at Gulp.set [as _setTask] (/home/leho/Documents/web-components/vaadin-lumo-styles/node_modules/undertaker/lib/set-task.js:10:3)
    at Gulp.task (/home/leho/Documents/web-components/vaadin-lumo-styles/node_modules/undertaker/lib/task.js:13:8)
    at Object.<anonymous> (/home/leho/Documents/web-components/vaadin-lumo-styles/gulpfile.js:14:6)
    at Module._compile (internal/modules/cjs/loader.js:1158:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1178:10)
    at Module.load (internal/modules/cjs/loader.js:1002:32)
    at Function.Module._load (internal/modules/cjs/loader.js:901:14)
    at Module.require (internal/modules/cjs/loader.js:1044:19)
    at require (internal/modules/cjs/helpers.js:77:18)
    at execute (/home/leho/Documents/web-components/vaadin-lumo-styles/node_modules/gulp/node_modules/gulp-cli/lib/versioned/^4.0.0/index.js:36:18) {
  generatedMessage: false,
  code: 'ERR_ASSERTION',
  actual: false,
  expected: true,
  operator: '=='
}

@lkraav lkraav mentioned this issue Apr 12, 2020
Closed
@lkraav
Copy link
Contributor Author

lkraav commented Jun 14, 2020

https://stackoverflow.com/questions/51098749/everytime-i-run-gulp-anything-i-get-a-assertion-error-task-function-must-be seems to apply.

@lkraav
Copy link
Contributor Author

lkraav commented Jun 14, 2020

While I have Gulpfile now working with Gulp 4, I can see PR to this probably has to work with vaadin/vaadin-component-dev-dependencies#3

lkraav added a commit to conversionxl/vaadin-lumo-styles that referenced this issue Jun 15, 2020
@lkraav
fix: Node 12+ crashes gulp icons, requires gulp-^4.0.0
a305d12 
Fix vaadin#85

* gulp-^4.0.0 is provided by @vaadin/vaadin-component-dev-dependencies-^2.0.0

* .eslintrc.json: `async` functions require `parserOptions.ecmaVersion = 8`

* Gulpfile: Gulp 4 task architecture uses `gulp.series()` and
  `.parallel()` async strategy

  We use `.parallel()` only for lint tasks operating on distinct file sets

* Gulpfile: add simple `.on('error')` report callbacks to task pipelines
  missing such, avoid `events.js unhandled 'error' event` warnings if
  any pipeline reports errors

* Gulpfile: on Linux, `base64` requires explicit `-w 0` to disable line wrapping

@todo Not sure why `font-icons.html` output produces a reverse of
      unicode characters for `--lumo-icons-eye` vs `--lumo-icons-eye-disabled`

      Is the original commit faulty perhaps?

@todo Test for vaadin#66
@lkraav lkraav mentioned this issue Jun 15, 2020
Merged
2 tasks
lkraav added a commit to conversionxl/vaadin-lumo-styles that referenced this issue Jun 15, 2020
@lkraav
fix: Node 12+ crashes gulp icons, requires gulp-^4.0.0
a061b24 
Fix vaadin#85

* gulp-^4.0.0 is provided by @vaadin/vaadin-component-dev-dependencies-^2.0.0

* .eslintrc.json: `async` functions require `parserOptions.ecmaVersion = 8`

* Gulpfile: Gulp 4 task architecture uses `gulp.series()` and
  `.parallel()` async strategy

  We use `.parallel()` only for lint tasks operating on distinct file sets

* Gulpfile: add simple `.on('error')` report callbacks to task pipelines
  missing such, avoid `events.js unhandled 'error' event` warnings if
  any pipeline reports errors

* Gulpfile: on Linux, `base64` requires explicit `-w 0` to disable line wrapping

@todo Not sure why `font-icons.html` output produces a reverse of
      unicode characters for `--lumo-icons-eye` vs `--lumo-icons-eye-disabled`.
      Is the original commit faulty perhaps?

@todo Test for vaadin#66
lkraav added a commit to conversionxl/vaadin-lumo-styles that referenced this issue Jun 15, 2020
@lkraav
fix: Node 12+ crashes gulp icons, requires gulp-^4.0.0
e4397fc 
Fix vaadin#85

* gulp-^4.0.0 is provided by @vaadin/vaadin-component-dev-dependencies-^2.0.0

* .eslintrc.json: `async` functions require `parserOptions.ecmaVersion = 8`

* Gulpfile: Gulp 4 task architecture uses `gulp.series()` and
  `.parallel()` async strategy

  We use `.parallel()` only for lint tasks operating on distinct file sets

* Gulpfile: add simple `.on('error')` report callbacks to task pipelines
  missing such, avoid `events.js unhandled 'error' event` warnings if
  any pipeline reports errors

* Gulpfile: on Linux, `base64` requires explicit `-w 0` to disable line wrapping

TODO Not sure why `font-icons.html` output produces a reverse of
     unicode characters for `--lumo-icons-eye` vs `--lumo-icons-eye-disabled`.
     Is the original commit faulty perhaps?

TODO Test for vaadin#66
@jouni jouni closed this as completed in #88 Jun 30, 2020
web-padawan pushed a commit to vaadin/web-components that referenced this issue Mar 3, 2021
@lkraav
fix: Node 12+ crashes gulp icons, requires gulp-^4.0.0
5142247 
Fixes: vaadin/vaadin-lumo-styles#85

* gulp-^4.0.0 is provided by @vaadin/vaadin-component-dev-dependencies-^2.0.0

* .eslintrc.json: `async` functions require `parserOptions.ecmaVersion = 8`

* Gulpfile: Gulp 4 task architecture uses `gulp.series()` and
  `.parallel()` async strategy

  We use `.parallel()` only for lint tasks operating on distinct file sets

* Gulpfile: add simple `.on('error')` report callbacks to task pipelines
  missing such, avoid `events.js unhandled 'error' event` warnings if
  any pipeline reports errors

* Gulpfile: on Linux, `base64` requires explicit `-w 0` to disable line wrapping

TODO Not sure why `font-icons.html` output produces a reverse of
     unicode characters for `--lumo-icons-eye` vs `--lumo-icons-eye-disabled`.
     Is the original commit faulty perhaps?

TODO Test for vaadin/vaadin-lumo-styles#66
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Node 12+ crashes gulp icons, requires gulp-^4.0.0 conversionxl/vaadin-lumo-styles
1 participant
@lkraav