fix: use Math.round to get correct scroller first index (#8278)

vaadin · Dec 5, 2024 · c6dffd1 · c6dffd1
1 parent 2d9f7e4
commit c6dffd1
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/packages/date-picker/src/vaadin-infinite-scroller.js b/packages/date-picker/src/vaadin-infinite-scroller.js
@@ -371,7 +371,8 @@ export class InfiniteScroller extends HTMLElement {
 
   /** @private */
   _updateClones(viewPortOnly) {
-    this._firstIndex = ~~((this._buffers[0].translateY - this._initialScroll) / this.itemHeight) + this._initialIndex;
+    this._firstIndex =
+      Math.round((this._buffers[0].translateY - this._initialScroll) / this.itemHeight) + this._initialIndex;
 
     const scrollerRect = viewPortOnly ? this.$.scroller.getBoundingClientRect() : undefined;
     this._buffers.forEach((buffer, bufferIndex) => {

diff --git a/packages/date-picker/test/scroller.test.js b/packages/date-picker/test/scroller.test.js
@@ -125,3 +125,18 @@ describe('vaadin-infinite-scroller', () => {
     });
   });
 });
+
+describe('fractional item size', () => {
+  let scroller;
+
+  beforeEach(async () => {
+    scroller = fixtureSync('<vaadin-infinite-scroller></vaadin-infinite-scroller>');
+    scroller.bufferSize = 80;
+    scroller.style.setProperty('--vaadin-infinite-scroller-item-height', '30.0001px');
+    await activateScroller(scroller);
+  });
+
+  it('should be at the position 0', () => {
+    expect(scroller.position).to.be.closeTo(0, 0.001);
+  });
+});