fix: use Math.round to get correct scroller first index #8278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
force-pushed
the
fix/scroller-round
branch
from
30e3523 to
1033e84
Compare
|
web-padawan
changed the title
vursen
approved these changes
Dec 5, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Dec 5, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Dec 5, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Dec 5, 2024
web-padawan
added a commit
that referenced
this pull request
Dec 5, 2024
web-padawan
added a commit
that referenced
this pull request
Dec 5, 2024
web-padawan
added a commit
that referenced
this pull request
Dec 6, 2024
web-padawan
added a commit
that referenced
this pull request
Dec 6, 2024
|
This ticket/PR has been released with Vaadin 24.6.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1665
See #1665 (comment) for clarification.
Added a test that sets item height to
30.0001px- with the test setup, the first item should be0but with previous logic the item count is calculated incorrectly and the item text content becomes1.Type of change