refactor: only show submenu indicator if there are child items

[web-padawan]

Description

Part of #10417

if no item has children, remove the space after items (the placeholder for submenu indicator) [0.5 day]

Type of change

• Refactor

[knoobie]

This looks kinda out of place.. should this logic also apply on the left side (check mark) if none of the menu entries are checkable?

[web-padawan]

In theory yes, but that's a bit more complicated. There is an existing issue: #613

In short, the web component doesn't have a way to detect when the item is checkable, so we assume they are by default. This is also related to some missing a11y semantics - see #165 (comment)

[jouni]

That was also the idea. But currently it’s not possible to know with CSS if an item is checkable.

[jouni]

In the meantime, I think we should make it easy to hide that empty space in a menu if the developer knows none of the items are checkable. I added a class name to each individual item in StarPass in such cases, but I think it would be easier if it could be applied on the whole menu. But there’s no API for that, is there?

[web-padawan]

There is no API in the web component indeed. Let's maybe discuss it in #613.

[jouni]

Now I’m wondering, why do we even add that pseudo element by default on items that don't have sub-menu? Couldn't we just not do that, and only add it to items that have [aria-haspopup="true"]? No need for slot styles then, right?

[web-padawan]

@jouni Thanks, it does make sense. Updated base styles and reverted addition of these slot styles.
There is still a TODO about [menu-item-checked] that would need to be addressed separately.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud