Use native apostrophe for uk locale holiday names #1004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add GitHub pull request template
Upgrade dependency: change black version from 22.12.0 to 23.1.0
Replace `relativedelta` with `timedelta` for days offset calculation
Refactor days offset calculation: replace `relativedelta` with `timedelta` (tests)
Montenegro optimization
Bosnia and Herzegovina holidays update
Bolivia holidays update
Jamaica holidays update
* Initial ARG revamped logic + testcases * AR: Ukranian Loc Part 1 Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com> * AR: Ukranian Loc Part 2 Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com> * AR: en_US Loc Part 1 Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com> * AR: Ukranian Loc Part 3 Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com> * AR: improve trigger Part 1 Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com> * AR: improve test case Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com> * AR: Veterans Day logic improvements Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com> * AR: Belgrano/Flag Day logic improvements Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com> * AR: San Martin Day special case for 2011 check Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com> * AR: Malvinas Sovereignty Day logic improvements Co-Authored-By: ~Jhellico <KJhellico@users.noreply.github.com> * AR: Implemented Arkid15r's suggestions Co-Authored-By: Arkadii Yakovets <2201626+arkid15r@users.noreply.github.com> * AR: Stricter PEP 8 Adherance Co-Authored-By: Arkadii Yakovets <2201626+arkid15r@users.noreply.github.com> --------- Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com> Co-authored-by: Arkadii Yakovets <2201626+arkid15r@users.noreply.github.com>
Remove unused code from `tests/countries/__init__.py`.
* Refactor `HolidayBase::get_named`: - Add `lookup` parameter. - Add `contains/iexact/icontains/iexact` lookup types. - Keep the current behavior with `icontains` as default lookup type. * Optimize holiday name lookups. Use exact lookup for holiday name assertions.
* Use the built-in library for time zone functions * Improve coverage * Extend to JP
* Cleans up TH documentation & localization files * TH: Stricter PEP 8 Adherance
* Add tox-ini-fmt to .pre-commit-config.yaml. * Bump the version.
KJhellico
approved these changes
Mar 4, 2023
Merged
arkid15r
added a commit
to arkid15r/python-holidays
that referenced
this pull request
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Replace ' with ʼ for
ukholiday names.Type of change
Checklist
betabranch of the repositorymake pre-commit)make test)