Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Thai Calendar test case coverage #2090

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

PPsyrius
Copy link
Collaborator

@PPsyrius PPsyrius commented Oct 29, 2024

Proposed change

The recent simultaneous merge of #2081 and #2086 reduces Thai Calendar test coverage as those changes removed testcases for the year 2158, this PR increased that test coverage back to 100% again.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

Copy link

sonarcloud bot commented Oct 29, 2024

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (abcffe3) to head (79516f2).
Report is 5 commits behind head on dev.

Additional details and impacted files
@@             Coverage Diff             @@
##              dev     #2090      +/-   ##
===========================================
+ Coverage   99.98%   100.00%   +0.01%     
===========================================
  Files         191       191              
  Lines       11537     11537              
  Branches     1738      1738              
===========================================
+ Hits        11535     11537       +2     
+ Misses          1         0       -1     
+ Partials        1         0       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@arkid15r arkid15r added this pull request to the merge queue Oct 30, 2024
Merged via the queue into vacanza:dev with commit d31f03f Oct 30, 2024
29 checks passed
@PPsyrius PPsyrius deleted the thai_calendar_coverage branch October 30, 2024 04:55
@arkid15r arkid15r mentioned this pull request Nov 4, 2024
mstuttgart pushed a commit to multidadosti-erp/python-holidays that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants