Update Thailand holidays in 2025 #2081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2081 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 191 191
Lines 11547 11539 -8
Branches 1744 1740 -4
=========================================
- Hits 11547 11539 -8 ☔ View full report in Codecov by Sentry. |
KJhellico
reviewed
Oct 26, 2024
|
In L614: Thailand(categories=GOVERNMENT, years=range(1960, 2024)),everything works correctly (due to auto-expand), but for accuracy: Or maybe better to refactor this test with |
|
@KJhellico I ended up refactoring all Thailand test cases to modern standards, so additional reviews will be needed here. |
KJhellico
reviewed
Oct 27, 2024
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
Co-Authored-By: ~Jhellico <KJhellico@users.noreply.github.com>
Co-Authored-By: ~Jhellico <KJhellico@users.noreply.github.com>
|
10 tasks
KJhellico
reviewed
Oct 28, 2024
10 tasks
10 tasks
Merged
9 tasks
mstuttgart
pushed a commit
to multidadosti-erp/python-holidays
that referenced
this pull request
Nov 18, 2024
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Update Thailand holidays in 2025, as well as refractoring Thailand testcases to modern standards.
SUN-MON-TUEformat for "Songkran" holidays do indeed has in-lieu observance onWEDas seen in 2014 and 2025, and has been fixed accordingly.Type of change
holidaysfunctionality in general)Checklist
make pre-commit, it didn't generate any changesmake test, all tests passed locally