Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cambodia holidays: add Peace Day in Cambodia #2108

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

PPsyrius
Copy link
Collaborator

@PPsyrius PPsyrius commented Nov 5, 2024

Proposed change

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (60966ea) to head (a44af0b).
Report is 5 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev     #2108   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          192       192           
  Lines        11577     11579    +2     
  Branches      1741      1742    +1     
=========================================
+ Hits         11577     11579    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-Authored-By: ~Jhellico <KJhellico@users.noreply.github.com>
Copy link

sonarcloud bot commented Nov 6, 2024

@PPsyrius
Copy link
Collaborator Author

PPsyrius commented Nov 6, 2024

I'm thinking of adding some kind of hidden char remover to the pre-commit later to prevent that from being included in the first place again. 👀

Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup 👍

@arkid15r arkid15r added this pull request to the merge queue Nov 7, 2024
Merged via the queue into vacanza:dev with commit b9f19c9 Nov 7, 2024
29 checks passed
@PPsyrius PPsyrius deleted the kh_peace_day branch November 7, 2024 02:49
@KJhellico KJhellico mentioned this pull request Nov 18, 2024
mstuttgart pushed a commit to multidadosti-erp/python-holidays that referenced this pull request Nov 18, 2024
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants