-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Cambodia holidays: add Peace Day in Cambodia #2108
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2108 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 192 192
Lines 11577 11579 +2
Branches 1741 1742 +1
=========================================
+ Hits 11577 11579 +2 ☔ View full report in Codecov by Sentry. |
Co-Authored-By: ~Jhellico <KJhellico@users.noreply.github.com>
Quality Gate passedIssues Measures |
I'm thinking of adding some kind of hidden char remover to the pre-commit later to prevent that from being included in the first place again. 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the cleanup 👍
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
Proposed change
Type of change
holidays
functionality in general)Checklist
make check
, all checks and tests are green