Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Malaysia holidays: add th localization #2030

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

PPsyrius
Copy link
Collaborator

@PPsyrius PPsyrius commented Oct 2, 2024

Proposed change

Adds Thai (th) localization for Malaysia holidays (I did double-checked all typos this time).

Note

Thai Public Broadcasting Service (Thai PBS) is used as the primary source for Islamic holidays naming over Thai Wikipedia ones i.e. อีฎิ้ลฟิตริ instead of อีดิลฟิฏร์

For various royal wordings - Royal World Thailand's Title and Style Guide is used - the Sultan of Johor was conferred special title tier in Thai language compared to other Malaysian states, even without referring to his "Yang di-Pertuan Agong" status. [1] [2]

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (6f2e7e1) to head (0213688).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev     #2030   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          189       189           
  Lines        11479     11479           
  Branches      1795      1795           
=========================================
  Hits         11479     11479           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Oct 2, 2024

Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@arkid15r arkid15r added this pull request to the merge queue Oct 2, 2024
Merged via the queue into vacanza:dev with commit 9e1d9ba Oct 2, 2024
31 checks passed
@PPsyrius PPsyrius deleted the malaysia_th_l10n branch October 3, 2024 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants