Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Ignore trailing commas #39

Closed
pvarin opened this issue May 18, 2020 · 1 comment
Closed

Feature request: Ignore trailing commas #39

pvarin opened this issue May 18, 2020 · 1 comment

Comments

@pvarin
Copy link

pvarin commented May 18, 2020

A common workflow of mine is to comment/uncomment items in a JSON file. This fails if I comment out the last item in a list/dictionary because the new last item now has a trailing comma. Is there any appetite for allowing trailing commas? Would a PR that included this functionality get accepted?

@vaidik
Copy link
Owner

vaidik commented May 31, 2020

I totally understand that need and it can get really irritating. I personally use python files as configuration files in that case, Gives me more flexibility.

I would be happy to accept changes. The only conflict I have is that this library will start diverging from JSON standard, which was a goal. The only thing I ever wanted to keep here was comments. But may be it's time to let that go.

Go ahead. Send your changes.

@vaidik vaidik closed this as completed in 5ab5d14 Oct 5, 2020
vaidik added a commit that referenced this issue Oct 5, 2020
Ignore trailing commas (closes #39, closes #43)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants