-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
commentjson raises the wrong error type on trailing comma #43
Comments
Not fixing this directly. Instead of that support for trailing commas is being added to expand use-cases for commentjson. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For example, let's say commentjson is told to load the following:
This will be caught on
commentjson.py:170
as alark.exceptions.UnexpectedCharacters
exception. That seems reasonable. Unfortunately,commentjson.py:205
will then catch this as a genericException
and translate it into aJSONLibraryException(e)
. This is bad because it breaks API-compatibility with the Pythonjson
library, which would just raise aValueError
The text was updated successfully, but these errors were encountered: