refactor: improve readibility of resource check and error messages

enh: switch to using maps for az dedup
fix: update unit tests for new error messages and to cover edge cases

Signed-off-by: Artur Shad Nik

deps(deps): update module github.com/onsi/ginkgo/v2 to v2.19.1

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

ci: add reviewable-ext make target to update chart crds (#107)

chore(main): release 0.0.5 (#66)

:robot: I have created a release *beep* *boop*
---

[0.0.5](v0.0.4...v0.0.5)
(2024-07-26)

* add upstream dns validation
([#102](#102))
([50b317e](50b317e))

* **deps:** update kubernetes packages to v0.30.1
([#49](#49))
([377eece](377eece))
* **deps:** update kubernetes packages to v0.30.2
([#83](#83))
([726a2ce](726a2ce))
* **deps:** update module github.com/go-logr/logr to v1.4.2
([59edbe8](59edbe8))
* **deps:** update module github.com/maas/gomaasclient to v0.5.0
([#74](#74))
([26b3340](26b3340))
* **deps:** update module github.com/onsi/ginkgo/v2 to v2.19.0
([61ecc09](61ecc09))
* **deps:** update module github.com/validator-labs/validator to v0.0.41
([e0f3909](e0f3909))
* **deps:** update module github.com/validator-labs/validator to v0.0.42
([#81](#81))
([713d9f0](713d9f0))
* **deps:** update module github.com/validator-labs/validator to v0.0.43
([929bc17](929bc17))
* **deps:** update module sigs.k8s.io/cluster-api to v1.7.3
([052dee8](052dee8))
* **deps:** update module sigs.k8s.io/controller-runtime to v0.18.4
([a438000](a438000))

* **deps:** pin googleapis/release-please-action action to f3969c0
([#67](#67))
([9fef1b8](9fef1b8))
* **deps:** update actions/checkout digest to 0ad4b8f
([#61](#61))
([7d40608](7d40608))
* **deps:** update actions/checkout digest to a5ac7e5
([0d79ce6](0d79ce6))
* **deps:** update anchore/sbom-action action to v0.16.0
([cd9bab3](cd9bab3))
* **deps:** update codecov/codecov-action digest to 125fc84
([#69](#69))
([3ae8c36](3ae8c36))
* **deps:** update dependency go to v1.22.4
([#76](#76))
([47fe6e2](47fe6e2))
* **deps:** update docker/login-action digest to 0d4c9c5
([#70](#70))
([6b0f1a2](6b0f1a2))
* **deps:** update docker/setup-buildx-action digest to d70bba7
([#26](#26))
([41c699c](41c699c))
* **deps:** update gcr.io/kubebuilder/kube-rbac-proxy docker tag to
v0.16.0
([#47](#47))
([a53bf65](a53bf65))
* **deps:** update quay.io/validator-labs/validator-plugin-maas docker
tag to v0.0.42
([#80](#80))
([3653e6e](3653e6e))

* **deps:** update dependency go to v1.22.5
([#92](#92))
([b9cbe1d](b9cbe1d))
* **deps:** update kubernetes packages to v0.30.3
([#98](#98))
([8ae9189](8ae9189))
* **deps:** update module github.com/maas/gomaasclient to v0.6.0
([#90](#90))
([d00fb21](d00fb21))
* **deps:** update module github.com/onsi/ginkgo/v2 to v2.19.1
([93815c3](93815c3))
* **deps:** update module github.com/onsi/gomega to v1.34.0
([47cc390](47cc390))
* **deps:** update module github.com/validator-labs/validator to v0.0.44
([e135801](e135801))
* **deps:** update module github.com/validator-labs/validator to v0.0.46
([#96](#96))
([3bb0e30](3bb0e30))
* **deps:** update module github.com/validator-labs/validator to v0.0.47
([#100](#100))
([addb5d0](addb5d0))
* **deps:** update module github.com/validator-labs/validator to v0.0.48
([79092a1](79092a1))
* **deps:** update module github.com/validator-labs/validator to v0.0.49
([ba024df](ba024df))
* **deps:** update module sigs.k8s.io/cluster-api to v1.7.4
([0f646f9](0f646f9))

* change api format to match other plugins
([#99](#99))
([891a21b](891a21b))
* enable revive and address all lints
([#94](#94))
([796238b](796238b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

deps(deps): update module github.com/validator-labs/validator to v0.0.50

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

.release-please-manifest.json

@@ -1 +1 @@
-{".":"0.0.4"}
+{".":"0.0.5"}

CHANGELOG.md

@@ -1,5 +1,61 @@
 # Changelog
 
+## [0.0.5](https://github.com/validator-labs/validator-plugin-maas/compare/v0.0.4...v0.0.5) (2024-07-26)
+
+
+### Features
+
+* add upstream dns validation ([#102](https://github.com/validator-labs/validator-plugin-maas/issues/102)) ([50b317e](https://github.com/validator-labs/validator-plugin-maas/commit/50b317e7a3e370c51ade305f4164a0edb225ca97))
+
+
+### Bug Fixes
+
+* **deps:** update kubernetes packages to v0.30.1 ([#49](https://github.com/validator-labs/validator-plugin-maas/issues/49)) ([377eece](https://github.com/validator-labs/validator-plugin-maas/commit/377eece67c2edd9b181dcd0f6a639e936e8d7442))
+* **deps:** update kubernetes packages to v0.30.2 ([#83](https://github.com/validator-labs/validator-plugin-maas/issues/83)) ([726a2ce](https://github.com/validator-labs/validator-plugin-maas/commit/726a2cea156c9b43e53a5b3f8e6acda4e9736c2a))
+* **deps:** update module github.com/go-logr/logr to v1.4.2 ([59edbe8](https://github.com/validator-labs/validator-plugin-maas/commit/59edbe8e8f95c2f859678d815ec68d6c0fda866b))
+* **deps:** update module github.com/maas/gomaasclient to v0.5.0 ([#74](https://github.com/validator-labs/validator-plugin-maas/issues/74)) ([26b3340](https://github.com/validator-labs/validator-plugin-maas/commit/26b334004b60a296e321106999143b85df1ed24e))
+* **deps:** update module github.com/onsi/ginkgo/v2 to v2.19.0 ([61ecc09](https://github.com/validator-labs/validator-plugin-maas/commit/61ecc09d247a6cc88b35e1cd1422ea883195b02a))
+* **deps:** update module github.com/validator-labs/validator to v0.0.41 ([e0f3909](https://github.com/validator-labs/validator-plugin-maas/commit/e0f39096f8c9adde4a779ab76af830e43525850b))
+* **deps:** update module github.com/validator-labs/validator to v0.0.42 ([#81](https://github.com/validator-labs/validator-plugin-maas/issues/81)) ([713d9f0](https://github.com/validator-labs/validator-plugin-maas/commit/713d9f02787d380dba23a61a3b8924f0cc4afb6d))
+* **deps:** update module github.com/validator-labs/validator to v0.0.43 ([929bc17](https://github.com/validator-labs/validator-plugin-maas/commit/929bc17d29efc01f68a569aa8eb6ea3aee8492f9))
+* **deps:** update module sigs.k8s.io/cluster-api to v1.7.3 ([052dee8](https://github.com/validator-labs/validator-plugin-maas/commit/052dee8eab2791e1b00ced0ba037c29ca48bb5f4))
+* **deps:** update module sigs.k8s.io/controller-runtime to v0.18.4 ([a438000](https://github.com/validator-labs/validator-plugin-maas/commit/a438000b8855fae923d2e0d5f69bc29c995cfc24))
+
+
+### Other
+
+* **deps:** pin googleapis/release-please-action action to f3969c0 ([#67](https://github.com/validator-labs/validator-plugin-maas/issues/67)) ([9fef1b8](https://github.com/validator-labs/validator-plugin-maas/commit/9fef1b8f71845efee191156580019a7edf5c6b73))
+* **deps:** update actions/checkout digest to 0ad4b8f ([#61](https://github.com/validator-labs/validator-plugin-maas/issues/61)) ([7d40608](https://github.com/validator-labs/validator-plugin-maas/commit/7d40608b1fcfef9f7438f92154258b925928d4ea))
+* **deps:** update actions/checkout digest to a5ac7e5 ([0d79ce6](https://github.com/validator-labs/validator-plugin-maas/commit/0d79ce6b5e4d9424e6b33cd0543fbd523ae0bf84))
+* **deps:** update anchore/sbom-action action to v0.16.0 ([cd9bab3](https://github.com/validator-labs/validator-plugin-maas/commit/cd9bab323ce1bcf9ea82d7728eec8460c116ac27))
+* **deps:** update codecov/codecov-action digest to 125fc84 ([#69](https://github.com/validator-labs/validator-plugin-maas/issues/69)) ([3ae8c36](https://github.com/validator-labs/validator-plugin-maas/commit/3ae8c36bc808300861e2240ec967cd0241d2b5b1))
+* **deps:** update dependency go to v1.22.4 ([#76](https://github.com/validator-labs/validator-plugin-maas/issues/76)) ([47fe6e2](https://github.com/validator-labs/validator-plugin-maas/commit/47fe6e22698ac46db51df43663c01ea237feb32f))
+* **deps:** update docker/login-action digest to 0d4c9c5 ([#70](https://github.com/validator-labs/validator-plugin-maas/issues/70)) ([6b0f1a2](https://github.com/validator-labs/validator-plugin-maas/commit/6b0f1a29cc586393ed17d0bf11e8ca8bd35acdaf))
+* **deps:** update docker/setup-buildx-action digest to d70bba7 ([#26](https://github.com/validator-labs/validator-plugin-maas/issues/26)) ([41c699c](https://github.com/validator-labs/validator-plugin-maas/commit/41c699cf2ac1cba5c2b14ded653d67652bad6f25))
+* **deps:** update gcr.io/kubebuilder/kube-rbac-proxy docker tag to v0.16.0 ([#47](https://github.com/validator-labs/validator-plugin-maas/issues/47)) ([a53bf65](https://github.com/validator-labs/validator-plugin-maas/commit/a53bf6533fdfc9459a41d17322d991edc38947b1))
+* **deps:** update quay.io/validator-labs/validator-plugin-maas docker tag to v0.0.42 ([#80](https://github.com/validator-labs/validator-plugin-maas/issues/80)) ([3653e6e](https://github.com/validator-labs/validator-plugin-maas/commit/3653e6ee14919283504921e0a38ccb7ce19479a4))
+
+
+### Dependency Updates
+
+* **deps:** update dependency go to v1.22.5 ([#92](https://github.com/validator-labs/validator-plugin-maas/issues/92)) ([b9cbe1d](https://github.com/validator-labs/validator-plugin-maas/commit/b9cbe1d875541ee7c193401d6577390ba71a674e))
+* **deps:** update kubernetes packages to v0.30.3 ([#98](https://github.com/validator-labs/validator-plugin-maas/issues/98)) ([8ae9189](https://github.com/validator-labs/validator-plugin-maas/commit/8ae9189bb1cd443eb658a8c096af278d5d0e3f5e))
+* **deps:** update module github.com/maas/gomaasclient to v0.6.0 ([#90](https://github.com/validator-labs/validator-plugin-maas/issues/90)) ([d00fb21](https://github.com/validator-labs/validator-plugin-maas/commit/d00fb219dd5d48824fd63fefed9cd3cff97fdbdc))
+* **deps:** update module github.com/onsi/ginkgo/v2 to v2.19.1 ([93815c3](https://github.com/validator-labs/validator-plugin-maas/commit/93815c3946c4c61de027928f5ec494137de9c71a))
+* **deps:** update module github.com/onsi/gomega to v1.34.0 ([47cc390](https://github.com/validator-labs/validator-plugin-maas/commit/47cc390159d638c4b1155a8c41c1c59b17d52b30))
+* **deps:** update module github.com/validator-labs/validator to v0.0.44 ([e135801](https://github.com/validator-labs/validator-plugin-maas/commit/e13580155acd53b5b7feb9a2cde30508b16ed3e4))
+* **deps:** update module github.com/validator-labs/validator to v0.0.46 ([#96](https://github.com/validator-labs/validator-plugin-maas/issues/96)) ([3bb0e30](https://github.com/validator-labs/validator-plugin-maas/commit/3bb0e30333b055849f65b7e3443fe7cbc505d332))
+* **deps:** update module github.com/validator-labs/validator to v0.0.47 ([#100](https://github.com/validator-labs/validator-plugin-maas/issues/100)) ([addb5d0](https://github.com/validator-labs/validator-plugin-maas/commit/addb5d01b65a84548802f1797fc9985550f9fca5))
+* **deps:** update module github.com/validator-labs/validator to v0.0.48 ([79092a1](https://github.com/validator-labs/validator-plugin-maas/commit/79092a132f3cfa0fab34d81eee7ab3be80b1a779))
+* **deps:** update module github.com/validator-labs/validator to v0.0.49 ([ba024df](https://github.com/validator-labs/validator-plugin-maas/commit/ba024df408f5900963e727894350c8bf8a900ef7))
+* **deps:** update module sigs.k8s.io/cluster-api to v1.7.4 ([0f646f9](https://github.com/validator-labs/validator-plugin-maas/commit/0f646f93e8326b7dc2fc21c2f2fcbd48bd149ed0))
+
+
+### Refactoring
+
+* change api format to match other plugins ([#99](https://github.com/validator-labs/validator-plugin-maas/issues/99)) ([891a21b](https://github.com/validator-labs/validator-plugin-maas/commit/891a21bbd7b5492d0777ccbd4001a7f884187339))
+* enable revive and address all lints ([#94](https://github.com/validator-labs/validator-plugin-maas/issues/94)) ([796238b](https://github.com/validator-labs/validator-plugin-maas/commit/796238b8538fa2e578c6e6439a1d1791c233455e))
+
 ## [0.0.4](https://github.com/validator-labs/validator-plugin-maas/compare/v0.0.3...v0.0.4) (2024-05-17)
 
 

Makefile

@@ -6,3 +6,15 @@ IMG ?= quay.io/validator-labs/validator-plugin-maas:latest
 
 # Helm vars
 CHART_NAME=validator-plugin-maas
+
+.PHONY: dev
+dev:
+ devspace dev -n validator
+
+# Static Analysis / CI
+
+chartCrds = chart/validator-plugin-maas/crds/validation.spectrocloud.labs_maasvalidators.yaml
+
+reviewable-ext:
+ rm $(chartCrds)
+ cp config/crd/bases/validation.spectrocloud.labs_maasvalidators.yaml $(chartCrds)

chart/validator-plugin-maas/Chart.yaml

@@ -2,5 +2,5 @@ apiVersion: v2
 name: validator-plugin-maas
 description: Perform various validations against a MaaS instance
 type: application
-version: 0.0.4
+version: 0.0.5
 appVersion: 0.0.1

chart/validator-plugin-maas/README.md

@@ -24,7 +24,7 @@ The following table lists the configurable parameters of the Validator-plugin-ma
 | `controllerManager.manager.containerSecurityContext.allowPrivilegeEscalation` | | `false` |
 | `controllerManager.manager.containerSecurityContext.capabilities.drop` | | `["ALL"]` |
 | `controllerManager.manager.image.repository` | | `"quay.io/validator-labs/validator-plugin-maas"` |
-| `controllerManager.manager.image.tag` | x-release-please-version | `"v0.0.4"` |
+| `controllerManager.manager.image.tag` | x-release-please-version | `"v0.0.5"` |
 | `controllerManager.manager.resources.limits.cpu` | | `"500m"` |
 | `controllerManager.manager.resources.limits.memory` | | `"128Mi"` |
 | `controllerManager.manager.resources.requests.cpu` | | `"10m"` |