Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: enable revive and address all lints #94

Merged
merged 7 commits into from
Jul 10, 2024
Merged

Conversation

ahmad-ibra
Copy link
Contributor

@ahmad-ibra ahmad-ibra commented Jul 9, 2024

Description

  • Enable revive
  • Address all lints
  • Fix helm chart tests

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
+ Coverage   44.59%   45.83%   +1.23%     
==========================================
  Files           6        5       -1     
  Lines         296      288       -8     
==========================================
  Hits          132      132              
+ Misses        155      147       -8     
  Partials        9        9              
Files Coverage Δ
api/v1alpha1/maasvalidator_types.go 100.00% <ø> (ø)
api/v1alpha1/zz_generated.deepcopy.go 38.46% <ø> (ø)
cmd/main.go 0.00% <ø> (ø)
internal/controller/maasvalidator_controller.go 80.48% <100.00%> (ø)
internal/validators/maas_validator.go 39.13% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f646f9...43e2fbb. Read the comment docs.

@ahmad-ibra ahmad-ibra marked this pull request as ready for review July 9, 2024 21:36
@ahmad-ibra ahmad-ibra requested a review from a team as a code owner July 9, 2024 21:36
@ahmad-ibra ahmad-ibra requested a review from mattwelke July 9, 2024 21:36
@ahmad-ibra ahmad-ibra merged commit 796238b into main Jul 10, 2024
7 checks passed
@ahmad-ibra ahmad-ibra deleted the refactor/revive branch July 10, 2024 02:02
ahmad-ibra pushed a commit that referenced this pull request Jul 26, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.0.5](v0.0.4...v0.0.5)
(2024-07-26)


### Features

* add upstream dns validation
([#102](#102))
([50b317e](50b317e))


### Bug Fixes

* **deps:** update kubernetes packages to v0.30.1
([#49](#49))
([377eece](377eece))
* **deps:** update kubernetes packages to v0.30.2
([#83](#83))
([726a2ce](726a2ce))
* **deps:** update module github.com/go-logr/logr to v1.4.2
([59edbe8](59edbe8))
* **deps:** update module github.com/maas/gomaasclient to v0.5.0
([#74](#74))
([26b3340](26b3340))
* **deps:** update module github.com/onsi/ginkgo/v2 to v2.19.0
([61ecc09](61ecc09))
* **deps:** update module github.com/validator-labs/validator to v0.0.41
([e0f3909](e0f3909))
* **deps:** update module github.com/validator-labs/validator to v0.0.42
([#81](#81))
([713d9f0](713d9f0))
* **deps:** update module github.com/validator-labs/validator to v0.0.43
([929bc17](929bc17))
* **deps:** update module sigs.k8s.io/cluster-api to v1.7.3
([052dee8](052dee8))
* **deps:** update module sigs.k8s.io/controller-runtime to v0.18.4
([a438000](a438000))


### Other

* **deps:** pin googleapis/release-please-action action to f3969c0
([#67](#67))
([9fef1b8](9fef1b8))
* **deps:** update actions/checkout digest to 0ad4b8f
([#61](#61))
([7d40608](7d40608))
* **deps:** update actions/checkout digest to a5ac7e5
([0d79ce6](0d79ce6))
* **deps:** update anchore/sbom-action action to v0.16.0
([cd9bab3](cd9bab3))
* **deps:** update codecov/codecov-action digest to 125fc84
([#69](#69))
([3ae8c36](3ae8c36))
* **deps:** update dependency go to v1.22.4
([#76](#76))
([47fe6e2](47fe6e2))
* **deps:** update docker/login-action digest to 0d4c9c5
([#70](#70))
([6b0f1a2](6b0f1a2))
* **deps:** update docker/setup-buildx-action digest to d70bba7
([#26](#26))
([41c699c](41c699c))
* **deps:** update gcr.io/kubebuilder/kube-rbac-proxy docker tag to
v0.16.0
([#47](#47))
([a53bf65](a53bf65))
* **deps:** update quay.io/validator-labs/validator-plugin-maas docker
tag to v0.0.42
([#80](#80))
([3653e6e](3653e6e))


### Dependency Updates

* **deps:** update dependency go to v1.22.5
([#92](#92))
([b9cbe1d](b9cbe1d))
* **deps:** update kubernetes packages to v0.30.3
([#98](#98))
([8ae9189](8ae9189))
* **deps:** update module github.com/maas/gomaasclient to v0.6.0
([#90](#90))
([d00fb21](d00fb21))
* **deps:** update module github.com/onsi/ginkgo/v2 to v2.19.1
([93815c3](93815c3))
* **deps:** update module github.com/onsi/gomega to v1.34.0
([47cc390](47cc390))
* **deps:** update module github.com/validator-labs/validator to v0.0.44
([e135801](e135801))
* **deps:** update module github.com/validator-labs/validator to v0.0.46
([#96](#96))
([3bb0e30](3bb0e30))
* **deps:** update module github.com/validator-labs/validator to v0.0.47
([#100](#100))
([addb5d0](addb5d0))
* **deps:** update module github.com/validator-labs/validator to v0.0.48
([79092a1](79092a1))
* **deps:** update module github.com/validator-labs/validator to v0.0.49
([ba024df](ba024df))
* **deps:** update module sigs.k8s.io/cluster-api to v1.7.4
([0f646f9](0f646f9))


### Refactoring

* change api format to match other plugins
([#99](#99))
([891a21b](891a21b))
* enable revive and address all lints
([#94](#94))
([796238b](796238b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
arturshadnik added a commit that referenced this pull request Jul 26, 2024
enh: switch to using maps for az dedup
fix: update unit tests for new error messages and to cover edge cases

Signed-off-by: Artur Shad Nik

deps(deps): update module github.com/onsi/ginkgo/v2 to v2.19.1

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

ci: add reviewable-ext make target to update chart crds (#107)

chore(main): release 0.0.5 (#66)

:robot: I have created a release *beep* *boop*
---

[0.0.5](v0.0.4...v0.0.5)
(2024-07-26)

* add upstream dns validation
([#102](#102))
([50b317e](50b317e))

* **deps:** update kubernetes packages to v0.30.1
([#49](#49))
([377eece](377eece))
* **deps:** update kubernetes packages to v0.30.2
([#83](#83))
([726a2ce](726a2ce))
* **deps:** update module github.com/go-logr/logr to v1.4.2
([59edbe8](59edbe8))
* **deps:** update module github.com/maas/gomaasclient to v0.5.0
([#74](#74))
([26b3340](26b3340))
* **deps:** update module github.com/onsi/ginkgo/v2 to v2.19.0
([61ecc09](61ecc09))
* **deps:** update module github.com/validator-labs/validator to v0.0.41
([e0f3909](e0f3909))
* **deps:** update module github.com/validator-labs/validator to v0.0.42
([#81](#81))
([713d9f0](713d9f0))
* **deps:** update module github.com/validator-labs/validator to v0.0.43
([929bc17](929bc17))
* **deps:** update module sigs.k8s.io/cluster-api to v1.7.3
([052dee8](052dee8))
* **deps:** update module sigs.k8s.io/controller-runtime to v0.18.4
([a438000](a438000))

* **deps:** pin googleapis/release-please-action action to f3969c0
([#67](#67))
([9fef1b8](9fef1b8))
* **deps:** update actions/checkout digest to 0ad4b8f
([#61](#61))
([7d40608](7d40608))
* **deps:** update actions/checkout digest to a5ac7e5
([0d79ce6](0d79ce6))
* **deps:** update anchore/sbom-action action to v0.16.0
([cd9bab3](cd9bab3))
* **deps:** update codecov/codecov-action digest to 125fc84
([#69](#69))
([3ae8c36](3ae8c36))
* **deps:** update dependency go to v1.22.4
([#76](#76))
([47fe6e2](47fe6e2))
* **deps:** update docker/login-action digest to 0d4c9c5
([#70](#70))
([6b0f1a2](6b0f1a2))
* **deps:** update docker/setup-buildx-action digest to d70bba7
([#26](#26))
([41c699c](41c699c))
* **deps:** update gcr.io/kubebuilder/kube-rbac-proxy docker tag to
v0.16.0
([#47](#47))
([a53bf65](a53bf65))
* **deps:** update quay.io/validator-labs/validator-plugin-maas docker
tag to v0.0.42
([#80](#80))
([3653e6e](3653e6e))

* **deps:** update dependency go to v1.22.5
([#92](#92))
([b9cbe1d](b9cbe1d))
* **deps:** update kubernetes packages to v0.30.3
([#98](#98))
([8ae9189](8ae9189))
* **deps:** update module github.com/maas/gomaasclient to v0.6.0
([#90](#90))
([d00fb21](d00fb21))
* **deps:** update module github.com/onsi/ginkgo/v2 to v2.19.1
([93815c3](93815c3))
* **deps:** update module github.com/onsi/gomega to v1.34.0
([47cc390](47cc390))
* **deps:** update module github.com/validator-labs/validator to v0.0.44
([e135801](e135801))
* **deps:** update module github.com/validator-labs/validator to v0.0.46
([#96](#96))
([3bb0e30](3bb0e30))
* **deps:** update module github.com/validator-labs/validator to v0.0.47
([#100](#100))
([addb5d0](addb5d0))
* **deps:** update module github.com/validator-labs/validator to v0.0.48
([79092a1](79092a1))
* **deps:** update module github.com/validator-labs/validator to v0.0.49
([ba024df](ba024df))
* **deps:** update module sigs.k8s.io/cluster-api to v1.7.4
([0f646f9](0f646f9))

* change api format to match other plugins
([#99](#99))
([891a21b](891a21b))
* enable revive and address all lints
([#94](#94))
([796238b](796238b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

deps(deps): update module github.com/validator-labs/validator to v0.0.50

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants