fix: handle basic auth for OCI client #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… env; init basic auth for OCI client Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
dosubot
bot
added
the
size:XL
TylerGillson
requested review from
ahmad-ibra
and removed request for
arturshadnik
dosubot
bot
added
bug
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
dosubot
bot
added
size:L
TylerGillson
changed the title
ahmad-ibra
previously approved these changes
Jul 18, 2024
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
ahmad-ibra
previously approved these changes
Jul 18, 2024
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
ahmad-ibra
previously approved these changes
Jul 18, 2024
Codecov ReportAttention: Patch coverage is @@ Coverage Diff @@
## main #333 +/- ##
==========================================
+ Coverage 46.38% 48.62% +2.23%
==========================================
Files 23 22 -1
Lines 1343 1273 -70
==========================================
- Hits 623 619 -4
+ Misses 653 586 -67
- Partials 67 68 +1
Continue to review full report in Codecov by Sentry.
|
TylerGillson
added a commit
to validator-labs/validator-plugin-oci
that referenced
this pull request
Jul 19, 2024
## Issue Addresses #65 ## Description - add public OCI client (that handles basic auth and proxy from env in HTTP transport) - fail validation results if they specify invalid public key secrets - add kv pairs from auth secrets to the environment (for ECR auth keychain) - add support for InsecureSkipTLSVerify Required by: - validator-labs/validator#333 --------- Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
dosubot
bot
added
size:XXL
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
ahmad-ibra
previously approved these changes
Jul 19, 2024
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
ahmad-ibra
previously approved these changes
Jul 19, 2024
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
TylerGillson
added a commit
that referenced
this pull request
Jul 21, 2024
🤖 I have created a release *beep* *boop* --- ## [0.0.47](v0.0.46...v0.0.47) (2024-07-20) ### Bug Fixes * handle basic auth for OCI client ([#333](#333)) ([5041c4f](5041c4f)) * make string utils avail externally ([#335](#335)) ([81d7d46](81d7d46)) ### Other * move string utils to central location ([#334](#334)) ([44c09ab](44c09ab)) ### Docs * recommend validatorctl; document Hauler ([#326](#326)) ([18a8fef](18a8fef)) * Update air-gapped prereqs in README.md ([de015d9](de015d9)) ### Dependency Updates * **deps:** update golang.org/x/exp digest to 8a7402a ([#336](#336)) ([8f94947](8f94947)) * **deps:** update golang.org/x/exp digest to 8a7402a ([#338](#338)) ([e012a4e](e012a4e)) * **deps:** update golang.org/x/exp digest to e3f2596 ([#329](#329)) ([3419300](3419300)) * **deps:** update kubernetes packages to v0.30.3 ([#332](#332)) ([5d4486c](5d4486c)) * **deps:** update module github.com/google/go-containerregistry to v0.20.1 ([#330](#330)) ([81fd1cf](81fd1cf)) * **deps:** update module github.com/slack-go/slack to v0.13.1 ([#328](#328)) ([089d25d](089d25d)) * **deps:** update module github.com/validator-labs/validator-plugin-oci to v0.0.11 ([#339](#339)) ([70a26e1](70a26e1)) * **deps:** update softprops/action-gh-release digest to c062e08 ([#331](#331)) ([c797383](c797383)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
TylerGillson
added a commit
to validator-labs/validatorctl
that referenced
this pull request
Jul 21, 2024
## Description Allow users to specify basic auth credentials _OR_ arbitrary environment variables when configuring OCI registry secrets. Other - Add automation to ensure validator versions stay up-to-date - Remove hacky 20s wait for plugins to being installing. Wait for plugin conditions to appear on ValidatorConfig instead. Requires: - validator-labs/validator#333 --------- Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
hauler-manifest.yamlandchart/validator/values.yamlRequires: