Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make string utils avail externally #335

Merged
merged 2 commits into from
Jul 19, 2024
Merged

fix: make string utils avail externally #335

merged 2 commits into from
Jul 19, 2024

Conversation

arturshadnik
Copy link
Member

Issue

None

Description

Move string utils to the correct directory for access outside of package

Signed-off-by: Artur Shad Nik artur@spectrocloud.com

@arturshadnik arturshadnik requested a review from a team as a code owner July 19, 2024 18:36
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 19, 2024
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

@@            Coverage Diff             @@
##             main     #335      +/-   ##
==========================================
+ Coverage   45.17%   46.38%   +1.21%     
==========================================
  Files          22       23       +1     
  Lines        1317     1343      +26     
==========================================
+ Hits          595      623      +28     
+ Misses        654      653       -1     
+ Partials       68       67       -1     
Files Coverage Δ
pkg/util/strings.go 100.00% <ø> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44c09ab...3fa1592. Read the comment docs.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 19, 2024
@TylerGillson TylerGillson merged commit 81d7d46 into main Jul 19, 2024
4 of 6 checks passed
@TylerGillson TylerGillson deleted the fix/utils branch July 19, 2024 19:01
TylerGillson added a commit that referenced this pull request Jul 21, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.0.47](v0.0.46...v0.0.47)
(2024-07-20)


### Bug Fixes

* handle basic auth for OCI client
([#333](#333))
([5041c4f](5041c4f))
* make string utils avail externally
([#335](#335))
([81d7d46](81d7d46))


### Other

* move string utils to central location
([#334](#334))
([44c09ab](44c09ab))


### Docs

* recommend validatorctl; document Hauler
([#326](#326))
([18a8fef](18a8fef))
* Update air-gapped prereqs in README.md
([de015d9](de015d9))


### Dependency Updates

* **deps:** update golang.org/x/exp digest to 8a7402a
([#336](#336))
([8f94947](8f94947))
* **deps:** update golang.org/x/exp digest to 8a7402a
([#338](#338))
([e012a4e](e012a4e))
* **deps:** update golang.org/x/exp digest to e3f2596
([#329](#329))
([3419300](3419300))
* **deps:** update kubernetes packages to v0.30.3
([#332](#332))
([5d4486c](5d4486c))
* **deps:** update module github.com/google/go-containerregistry to
v0.20.1 ([#330](#330))
([81fd1cf](81fd1cf))
* **deps:** update module github.com/slack-go/slack to v0.13.1
([#328](#328))
([089d25d](089d25d))
* **deps:** update module github.com/validator-labs/validator-plugin-oci
to v0.0.11
([#339](#339))
([70a26e1](70a26e1))
* **deps:** update softprops/action-gh-release digest to c062e08
([#331](#331))
([c797383](c797383))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants