Merge pull request #1995 from mortbauer/fix/isURL-empty-host-with-query

do not check if the host is valid if no host is specified and not require_host
validatorjs · Jul 17, 2022 · 9f89f3b · 9f89f3b
2 parents d5f8015 + 5d2ff83
commit 9f89f3b
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 0 deletions.
diff --git a/src/lib/isURL.js b/src/lib/isURL.js
@@ -152,6 +152,11 @@ export default function isURL(url, options) {
  if (options.host_whitelist) {
  return checkHost(host, options.host_whitelist);
  }
+
+ if (host === '' && !options.require_host) {
+ return true;
+ }
+
  if (!isIP(host) && !isFQDN(host, options) && (!ipv6 || !isIP(ipv6, 6))) {
  return false;
  }

diff --git a/test/validators.js b/test/validators.js
@@ -472,6 +472,24 @@ describe('Validators', () => {
  });
  });
 
+ it('should validate postgres URLs without a host', () => {
+ test({
+ validator: 'isURL',
+ args: [{
+ protocols: ['postgres'],
+ require_host: false,
+ }],
+ valid: [
+ 'postgres://user:pw@/test',
+ ],
+ invalid: [
+ 'http://foobar.com',
+ 'postgres://',
+ ],
+ });
+ });
+
+
  it('should validate URLs with any protocol', () => {
  test({
  validator: 'isURL',