Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not check if the host is valid if no host is specified and not require_host #1995

Merged

Conversation

mortbauer
Copy link
Contributor

Fix the isURL check to not check the host if the host part is empty and require_host is false

This PR fixes isse #1994

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Jul 2, 2022

Codecov Report

Merging #1995 (5d2ff83) into master (37cbd5c) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #1995   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          103       103           
  Lines         2099      2101    +2     
  Branches       474       475    +1     
=========================================
+ Hits          2099      2101    +2     
Impacted Files Coverage Δ
src/lib/isURL.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37cbd5c...5d2ff83. Read the comment docs.

@rubiin rubiin merged commit 9f89f3b into validatorjs:master Jul 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants