Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(isPassportNumber): added South African, ZA validator #2265

Merged
merged 3 commits into from
Aug 18, 2023

Conversation

GMorris-professional
Copy link
Contributor

feat(isPassportNumber): Added South African Passport Number Validation

Added the Regex for South African (ZA) passport numbers

Source: https://www.e4.co.za/downloads/passport.pdf

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (f074abd) 99.95% compared to head (ae83378) 99.95%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2265   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files         107      107           
  Lines        2436     2436           
  Branches      615      615           
=======================================
  Hits         2435     2435           
  Partials        1        1           
Files Changed Coverage Δ
src/lib/isPassportNumber.js 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GMorris-professional GMorris-professional changed the title Added the Regex for South African (ZA) passport numbers feat(isPassportNumber): Added South African Passport Number Validation Aug 16, 2023
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contrib! 🎉

@profnandaa profnandaa changed the title feat(isPassportNumber): Added South African Passport Number Validation feat(isPassportNumber): added South African, ZA validator Aug 18, 2023
@profnandaa profnandaa merged commit 6923860 into validatorjs:master Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants