Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maintenance: 2405 release #2269

Closed
wants to merge 27 commits into from
Closed

maintenance: 2405 release #2269

wants to merge 27 commits into from

Conversation

profnandaa
Copy link
Member

@profnandaa profnandaa commented Aug 18, 2023 •
edited
Loading

This is a B release, post the main last major one #2252 , mainly to fix the regression in isDate but escorted with a few more "feature patches".

This is being repurposed to the May 2024 release.

13.12.0

New Features / Validators

Fixes, New Locales and Enhancements

tomaspanek and others added 4 commits August 18, 2023 15:42
@tomaspanek
fix(isDate): Timezone Offset Fix (#2257)
2c4aede 
* Timezone Offset Fix & Parsing with Leading Zeros

* `isDate` Timezone Mock Test, Support for NodeJS <8

* `isDate` Unit Test Resiliency Improvement
@estefrare
feat(isTaxId): add tax id for Argentina, es-AR (#2224)
3541b0d
@GMorris-professional
feat(isPassportNumber): added South African, ZA validator (#2265)
6923860 
* Included Regex for South African Passport Number

* Corrected Passport validation

* Update README.md
@SimranSiddiqui
feat(isMobilePhone): Added the regex for Malawi en-MW (#2267)
b958bd7 
* Added the regex and tests for Malawi phone number validation

* Added the regex and tests for Malawi phone number validation

* Added the regex and tests for Malawi phone number validation
WikiRik
WikiRik approved these changes Aug 18, 2023
View reviewed changes
src/lib/isPassportNumber.js Show resolved Hide resolved
@profnandaa
Copy link
Member Author

Sorry I'll delay the release to Monday. I'm also struggling having clean builds but has nothing to do with the new changes.

@rubiin
Copy link
Member

rubiin commented Aug 21, 2023 •
edited
Loading

@profnandaa How about we include the types in the package itself. That way it will be more easier to maintain it along with the actual lib itself. Also from the consumer point of view, this will result in one less dep, not to mention it will result in a more robust typesafety for them as we will also be changing the types file here itself instead of waiting for DefinitelyTyped

@profnandaa
Copy link
Member Author

@profnandaa How about we include the types in the package itself. That way it will be more easier to maintain it along with the actual lib itself. Also from the consumer point of view, this will result in one less dep, not to mention it will result in a more robust typesafety for them as we will also be changing the types file here itself instead of waiting for DefinitelyTyped

@rubiin -- I don't mind that. Could you do a few samples to see how that will look like?

@rubiin
Copy link
Member

rubiin commented Aug 21, 2023 •
edited
Loading

@profnandaa How about we include the types in the package itself. That way it will be more easier to maintain it along with the actual lib itself. Also from the consumer point of view, this will result in one less dep, not to mention it will result in a more robust typesafety for them as we will also be changing the types file here itself instead of waiting for DefinitelyTyped

@rubiin -- I don't mind that. Could you do a few samples to see how that will look like?

I think most of it can be borrowed and added upon from https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/validator
We might have to add a info on post install to let users know to prefer our types over types in DefinitelyTyped.
The first version can be a simple copy paste.

@WikiRik WikiRik mentioned this pull request Sep 4, 2023
Closed
@WikiRik
Copy link
Member

WikiRik commented Sep 20, 2023

@profnandaa any chance we can get this release out soon?

@profnandaa
Copy link
Member Author

@WikiRik - struggled with getting a clean build last time and stalled. I need some help on that. Was building on latest Node.js stable.

@WikiRik
Copy link
Member

WikiRik commented Sep 20, 2023

What is the issue you got? I'm using Node 18.18.0 in a new GitHub Codespace with the default image and that works fine. You do need to use npm install --legacy-peer-deps, but that's a known issue (see #2123)

@tomaspanek tomaspanek mentioned this pull request Dec 2, 2023
Merged
4 tasks
ZhulinskiiDanil and others added 2 commits March 5, 2024 16:43
@ZhulinskiiDanil
fix(docs): misspelling of Mailto (#2368)
332b501
@WikiRik
chore(isMailtoURI): remove unnecessary default to (#2341)
4197b86 
* chore: add additional testcases to isMailtoURI

Line 44 is only partially covered before this change

* chore: add additonal const to figure out which part is partial

* chore: add testcase for single ?

* chore: add another line to find partial coverage

* chore: remove default to

* chore: combine consts again
@rubiin
Copy link
Member

rubiin commented Mar 28, 2024

I have add LGTM labels to few issues, we can add them to this pipeline

@devmanbud
fix(docs): fixed typo in README.md (#2371)
31c88cf 
Co-authored-by: Musa <goat_musa@Musas-MBP.cust.communityfibre.co.uk>
@profnandaa
Copy link
Member Author

@WikiRik --

this is the build errors I have been getting, I had to run with npm install --legacy-peer-deps to proceed.

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: rollup-plugin-babel@4.4.0
npm ERR! Found: rollup@0.47.6
npm ERR! node_modules/rollup
npm ERR!   dev rollup@"^0.47.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer rollup@">=0.60.0 <3" from rollup-plugin-babel@4.4.0
npm ERR! node_modules/rollup-plugin-babel
npm ERR!   dev rollup-plugin-babel@"^4.0.1" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: rollup@2.79.1
npm ERR! node_modules/rollup
npm ERR!   peer rollup@">=0.60.0 <3" from rollup-plugin-babel@4.4.0
npm ERR!   node_modules/rollup-plugin-babel
npm ERR!     dev rollup-plugin-babel@"^4.0.1" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Trying to upgrade these dev dependencies, sends everything else going crazy.
I'll need help on modernizing our dev dependencies, but I think this shouldn't block our next release. So, I'm going to work on getting the next release on Monday. Will open a new PR detailing the release.

Then we work on a follow up release in a month's time.

Thanks for your help in reviewing the PRs and keeping the lights on!

@profnandaa
Copy link
Member Author

Currently reviewing all the LGTMs - https://github.com/validatorjs/validator.js/pulls?q=is%3Apr+is%3Aopen+label%3A%22%E2%9C%85+LGTM%22

@profnandaa profnandaa changed the title maintenance: post 2308 release maintenance: 2404 release Apr 25, 2024
@amaliacatalina
fix(isPassportNumber): fix regex Azerbaijan (#2284)
752bd09 
* Update isPassportNumber.js

Added the updated Azerbaijan passport validation:
See issue:
#2274

* Update validators.test.js
RobinvanderVliet and others added 5 commits April 25, 2024 12:55
@profnandaa
Copy link
Member Author

UPDATE: now pending this mc-to-land s, which I'll do a fix PR for all of them, and then prep the release notes - https://github.com/validatorjs/validator.js/pulls?q=is%3Apr+is%3Aopen+label%3Amc-to-land

rubiin and others added 2 commits April 25, 2024 13:16
@rubiin @WikiRik
ci: add latest node versions (#2364)
817e56e 
Co-authored-by: Rik Smale <13023439+WikiRik@users.noreply.github.com>
@GMorris-professional
fix(isPassport): added tests for ZA Passport Number (#2270)
72c8dc1
@rubiin
Copy link
Member

rubiin commented Apr 27, 2024

Lets try to include more stale prs(mc-to-land) as the number of prs are alot and the number might create a false impression for new contributors as well as users on the libs active status

urg and others added 3 commits April 27, 2024 17:03
@urg
fix: add SLE to the isISO4217 validator (#2273)
5677f91
@meyfa
chore: Publish to NPM with provenance (#2276)
2253a77 
* chore: Publish to NPM with provenance

The release process in this repository is already automated via
GitHub Actions, which is a great first step toward creating trust in the
supply chain. Recently, NPM has started to support publishing with the
`--provenance` flag. This flag creates a link between the GitHub Actions
run that created the release and the final artifact on NPM. This linkage
further ensures that package installs can be traced back to a specific
code revision.

For more information on publishing with provenance, please refer to:
https://github.blog/2023-04-19-introducing-npm-package-provenance/

* chore: Use Node.js 18 for publishing to support provenance
@nandavikas
fix: symbolRegex in isStrongPassword to include '\' (#2278)
8a40349 
* Modified symbolRegex in isStrongPassword to include '\'

* Modify test to check validity of strong password with \ character
@rubiin
Copy link
Member

rubiin commented Apr 27, 2024

@WikiRik --

this is the build errors I have been getting, I had to run with npm install --legacy-peer-deps to proceed.

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: rollup-plugin-babel@4.4.0
npm ERR! Found: rollup@0.47.6
npm ERR! node_modules/rollup
npm ERR!   dev rollup@"^0.47.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer rollup@">=0.60.0 <3" from rollup-plugin-babel@4.4.0
npm ERR! node_modules/rollup-plugin-babel
npm ERR!   dev rollup-plugin-babel@"^4.0.1" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: rollup@2.79.1
npm ERR! node_modules/rollup
npm ERR!   peer rollup@">=0.60.0 <3" from rollup-plugin-babel@4.4.0
npm ERR!   node_modules/rollup-plugin-babel
npm ERR!     dev rollup-plugin-babel@"^4.0.1" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Trying to upgrade these dev dependencies, sends everything else going crazy. I'll need help on modernizing our dev dependencies, but I think this shouldn't block our next release. So, I'm going to work on getting the next release on Monday. Will open a new PR detailing the release.

Then we work on a follow up release in a month's time.

Thanks for your help in reviewing the PRs and keeping the lights on!

#2391 this should fix the problem both on CI and local installs.

@profnandaa profnandaa changed the title maintenance: 2404 release maintenance: 2405 release May 2, 2024
@profnandaa
Copy link
Member Author

@rubiin @WikiRik @ezkemboi -- kindly take a look at the release notes (PR description) one last time and I should make the release today evening GMT.

WikiRik
WikiRik approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@WikiRik WikiRik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the update and the merger of recent PRs!

@WikiRik WikiRik mentioned this pull request May 7, 2024
Closed
@profnandaa
Copy link
Member Author

13.12.0 now released. Thanks all for the contribution! 🎉 https://www.npmjs.com/package/validator/v/13.12.0
And once again, thanks @WikiRik and @rubiin for your reviews!

@profnandaa profnandaa closed this May 9, 2024
@profnandaa profnandaa mentioned this pull request Dec 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMorris-professional GMorris-professional GMorris-professional left review comments

@ezkemboi ezkemboi ezkemboi approved these changes

@WikiRik WikiRik WikiRik approved these changes

@rubiin rubiin rubiin approved these changes

@pano9000 pano9000 Awaiting requested review from pano9000

Assignees
No one assigned
Labels
dont-merge maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.