Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(isVAT): fixed KZ VAT number length check #2279

Merged
merged 2 commits into from
Apr 27, 2024
Merged

fix(isVAT): fixed KZ VAT number length check #2279

merged 2 commits into from
Apr 27, 2024

Conversation

MatthieuLemoine
Copy link
Contributor

@MatthieuLemoine MatthieuLemoine commented Aug 30, 2023 •
edited
Loading

According to Wikipedia and the source linked in this article, Kazakh VAT numbers are 12 digits long, not 9.

image

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (b958bd7) 99.95% compared to head (6fa00af) 99.95%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2279   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files         107      107           
  Lines        2454     2454           
  Branches      619      619           
=======================================
  Hits         2453     2453           
  Partials        1        1
Files Changed Coverage Δ
src/lib/isVAT.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@profnandaa profnandaa merged commit 11ac6a4 into validatorjs:master Apr 27, 2024
9 checks passed
@profnandaa profnandaa mentioned this pull request May 2, 2024
Closed
@kaifkh20 kaifkh20 mentioned this pull request May 30, 2024
Open
@Safar123 Safar123 mentioned this pull request May 30, 2024
Open
@IT21149412 IT21149412 mentioned this pull request May 30, 2024
Open
@Achmad-Farid Achmad-Farid mentioned this pull request May 30, 2024
Open
@ahmetilboga2004 ahmetilboga2004 mentioned this pull request May 30, 2024
Merged
@wambugucoder wambugucoder mentioned this pull request May 30, 2024
Open
@TuanNB28 TuanNB28 mentioned this pull request May 30, 2024
Open
@StemmlerSisters StemmlerSisters mentioned this pull request May 30, 2024
Open
@peterboni peterboni mentioned this pull request May 30, 2024
Open
@rntvicente rntvicente mentioned this pull request May 30, 2024
Open
@DefenderK DefenderK mentioned this pull request May 30, 2024
Closed
@ChinmoyHembram ChinmoyHembram mentioned this pull request May 30, 2024
Open
@saileshbro saileshbro mentioned this pull request May 30, 2024
Merged
@malforsaja malforsaja mentioned this pull request May 30, 2024
Merged
@ryanlelek ryanlelek mentioned this pull request May 30, 2024
Closed
@ziccardi ziccardi mentioned this pull request May 30, 2024
Open
@MoTarigOs MoTarigOs mentioned this pull request May 30, 2024
Open
@pasang7 pasang7 mentioned this pull request May 30, 2024
Open
@ceconcarlsen ceconcarlsen mentioned this pull request May 31, 2024
Open
@sumandas0 sumandas0 mentioned this pull request May 31, 2024
Open
@vky5 vky5 mentioned this pull request May 31, 2024
Closed
@shaneclulow shaneclulow mentioned this pull request May 31, 2024
Open
@isomeradmin isomeradmin mentioned this pull request May 31, 2024
Merged
@zolamk zolamk mentioned this pull request Jun 3, 2024
Closed
@IT21221064 IT21221064 mentioned this pull request Sep 14, 2024
Open
@officialmofabs officialmofabs mentioned this pull request Sep 14, 2024
Open
@WontonSam WontonSam mentioned this pull request Sep 14, 2024
Open
@vky5 vky5 mentioned this pull request Sep 15, 2024
Closed
@amay0808 amay0808 mentioned this pull request Sep 16, 2024
Open
@IT21269134 IT21269134 mentioned this pull request Sep 17, 2024
Open
This was referenced Sep 17, 2024
Open
Open
@diviyanjanakamesh diviyanjanakamesh mentioned this pull request Sep 18, 2024
Open
@MohammadGhajari MohammadGhajari mentioned this pull request Sep 18, 2024
Open
@diviyanjanakamesh diviyanjanakamesh mentioned this pull request Sep 19, 2024
Open
@ch4mi2 ch4mi2 mentioned this pull request Sep 19, 2024
Closed
@maleeshaaa maleeshaaa mentioned this pull request Sep 19, 2024
Open
@MohammadGhajari MohammadGhajari mentioned this pull request Sep 19, 2024
Open
@ChinmoyHembram ChinmoyHembram mentioned this pull request Sep 19, 2024
Open
@officialmofabs officialmofabs mentioned this pull request Sep 19, 2024
Open
This was referenced Sep 20, 2024
Open
Open
@ChinmoyHembram ChinmoyHembram mentioned this pull request Sep 21, 2024
Open
@tamir-ariunsukh tamir-ariunsukh mentioned this pull request Sep 21, 2024
Open
@KOTTAGENVH KOTTAGENVH mentioned this pull request Sep 21, 2024
Open
@officialmofabs officialmofabs mentioned this pull request Sep 21, 2024
Open
@MohammadGhajari MohammadGhajari mentioned this pull request Sep 22, 2024
Open
@tamir-ariunsukh tamir-ariunsukh mentioned this pull request Sep 22, 2024
Open
This was referenced Sep 22, 2024
Open
Open
@MohammadGhajari MohammadGhajari mentioned this pull request Sep 23, 2024
Open
@pasanchamikara99 pasanchamikara99 mentioned this pull request Sep 26, 2024
Open
@KOTTAGENVH KOTTAGENVH mentioned this pull request Sep 27, 2024
Open
@DefenderK DefenderK mentioned this pull request Oct 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@profnandaa profnandaa profnandaa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MatthieuLemoine @profnandaa