Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add latest node versions #2364

Merged
merged 5 commits into from
Apr 25, 2024
Merged

ci: add latest node versions #2364

merged 5 commits into from
Apr 25, 2024

Conversation

rubiin
Copy link
Member

@rubiin rubiin commented Jan 26, 2024

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

@rubiin rubiin marked this pull request as draft January 26, 2024 18:53
Copy link
Member

@WikiRik WikiRik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating line 23 to npm install --legacy-peer-deps should fix the failing CI

Copy link

codecov bot commented Jan 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4197b86) to head (b39e088).

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2364   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          107       107           
  Lines         2449      2449           
  Branches       619       619           
=========================================
  Hits          2449      2449           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rubiin rubiin marked this pull request as ready for review January 27, 2024 21:16
@rubiin rubiin requested review from WikiRik and pano9000 January 27, 2024 21:17
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Co-authored-by: Rik Smale <13023439+WikiRik@users.noreply.github.com>
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Co-authored-by: Rik Smale <13023439+WikiRik@users.noreply.github.com>
Copy link
Member

@ezkemboi ezkemboi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems, reduced tests.
Also, we will need to do more testing on the latest versions

@rubiin rubiin requested review from WikiRik and ezkemboi March 27, 2024 14:24
@rubiin
Copy link
Member Author

rubiin commented Apr 25, 2024

@profnandaa this too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants