Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go: modules CI #2801

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

go: modules CI #2801

wants to merge 9 commits into from

Conversation

Yury-Fridlyand
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand commented Dec 10, 2024 •
edited
Loading

Depends and based on #2803

  1. New CI pipeline
  2. Couple of simple tests
  3. Getting server version using INFO command in IT
  4. Custom Command for cluster client (requires for 3 ^)
  5. New IT/MT command line flags - server addresses, tls
  6. Update for makefile
  7. Update for dev guide

New targets in makefile:

make unit-test
make integ-test
make modules-test

All accept additional parameters:

  • test-filter
  • cluster-endpoints
  • standalone-endpoints
  • tls

Example:

make integ-test cluster-endpoints=localhost:7000 standalone-endpoints=localhost:6379 tls=true test-filter=TestGlideTestSuite/TestPExpire

@Yury-Fridlyand
First PoC
48dc9c7 
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand
Modules CI
236896a 
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand
Merge remote-tracking branch 'upstream/main' into ci/go-modules
0bae604 
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand
cleanup
158e909 
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand Yury-Fridlyand added go golang wrapper CI/CD CI/CD related labels Dec 10, 2024
@Yury-Fridlyand Yury-Fridlyand requested a review from a team as a code owner December 10, 2024 20:39
@Yury-Fridlyand
fix
cb00408 
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand
fix
c050f36 
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand
fix
322ade5 
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand
fix
0465dbb 
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Yury-Fridlyand added a commit that referenced this pull request Dec 10, 2024
@Yury-Fridlyand
Protobuf: bump to 29.1 (#2801)
32530f6 
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand
fix
76069ab 
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Yury-Fridlyand
Yury-Fridlyand commented Dec 10, 2024
View reviewed changes
go/Cargo.toml
@@ -9,7 +9,7 @@ authors = ["Valkey GLIDE Maintainers"]
crate-type = ["cdylib"]

[dependencies]
redis = { path = "../glide-core/redis-rs/redis", features = ["aio", "tokio-comp", "tls", "tokio-native-tls-comp", "tls-rustls-insecure"] }
redis = { path = "../glide-core/redis-rs/redis", features = ["aio", "tokio-comp", "connection-manager", "tokio-rustls-comp"] }
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copied from java, TLS connection doesn't work without this change. I don't know actual list of features we require.

Yury-Fridlyand added a commit that referenced this pull request Dec 11, 2024
@Yury-Fridlyand
[Backport 1.2] Protobuf: bump to 29.1 (#2802)
79c3bc9 
* Protobuf: bump to 29.1 (#2801)

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
yipin-chen
yipin-chen approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@yipin-chen yipin-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

barshaul pushed a commit to barshaul/glide-for-redis that referenced this pull request Dec 12, 2024
@Yury-Fridlyand @barshaul
[Backport 1.2] Protobuf: bump to 29.1 (valkey-io#2802)
341cd9d 
* Protobuf: bump to 29.1 (valkey-io#2801)

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yipin-chen yipin-chen yipin-chen approved these changes

Assignees
No one assigned
Labels
CI/CD CI/CD related go golang wrapper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yury-Fridlyand @yipin-chen