-
Notifications
You must be signed in to change notification settings - Fork 117
Python: Add Batch support #3555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: Add Batch support #3555
Conversation
d4fb032 to
41dc46b
Compare
|
Please don't forget changelog |
bae1fb6 to
76dda70
Compare
shohamazon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job 🚀
Signed-off-by: BoazBD <boazbd@amazon.com>
Signed-off-by: BoazBD <boazbd@amazon.com>
Signed-off-by: BoazBD <boazbd@amazon.com>
Signed-off-by: BoazBD <boazbd@amazon.com>
Signed-off-by: BoazBD <boazbd@amazon.com>
Signed-off-by: BoazBD <boazbd@amazon.com>
Signed-off-by: BoazBD <boazbd@amazon.com>
Signed-off-by: BoazBD <boazbd@amazon.com>
Signed-off-by: BoazBD <boaz@bardavid.com>
0fe1f67 to
d898b8e
Compare
6d40316 to
8e3c30e
Compare
Signed-off-by: BoazBD <boaz@bardavid.com>
8e3c30e to
3dbbc48
Compare
Signed-off-by: BoazBD <boaz@bardavid.com>
Signed-off-by: BoazBD <boaz@bardavid.com>
shohamazon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌈
2fa6ba1 to
041bab0
Compare
Signed-off-by: BoazBD <boaz@bardavid.com>
a995279 to
32b400d
Compare
Signed-off-by: BoazBD <boaz@bardavid.com>
32b400d to
93c3e71
Compare
shohamazon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AMAZEEEEEE 😮 🔝 ❤️
Signed-off-by: BoazBD <boaz@bardavid.com>
7cf4f19 to
6473fcc
Compare
Signed-off-by: BoazBD <boaz@bardavid.com>
6473fcc to
01419ff
Compare
shohamazon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌷 🌈 ☁️ 🌃
* add python pipeline support Signed-off-by: BoazBD <boazbd@amazon.com> * shorten rows for flake8 Signed-off-by: BoazBD <boazbd@amazon.com> * add transaction timeout test and allign docs with java Signed-off-by: BoazBD <boazbd@amazon.com> * fix linters Signed-off-by: BoazBD <boazbd@amazon.com> * fix more linters and failed tests Signed-off-by: BoazBD <boazbd@amazon.com> * add requirements download to sphinx Signed-off-by: BoazBD <boazbd@amazon.com> * allign with lior's url changes Signed-off-by: BoazBD <boazbd@amazon.com> * fix imports sort Signed-off-by: BoazBD <boazbd@amazon.com> * fix shoham comments 1 Signed-off-by: BoazBD <boaz@bardavid.com> * fix docs indentation Signed-off-by: BoazBD <boaz@bardavid.com> * fix imports sort Signed-off-by: BoazBD <boaz@bardavid.com> * install types-Deprecated package Signed-off-by: BoazBD <boaz@bardavid.com> * fix indent in docs Signed-off-by: BoazBD <boaz@bardavid.com> * small doc fixes Signed-off-by: BoazBD <boaz@bardavid.com> * please work Signed-off-by: BoazBD <boaz@bardavid.com> * now u must work Signed-off-by: BoazBD <boaz@bardavid.com> * helllllp Signed-off-by: BoazBD <boaz@bardavid.com> * fix shoham comments 2 Signed-off-by: BoazBD <boaz@bardavid.com> * fix imports and add route test Signed-off-by: BoazBD <boaz@bardavid.com> * fix shoham comments 3 Signed-off-by: BoazBD <boaz@bardavid.com> * fix mset docs Signed-off-by: BoazBD <boaz@bardavid.com> --------- Signed-off-by: BoazBD <boazbd@amazon.com> Signed-off-by: BoazBD <boaz@bardavid.com> Co-authored-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>
| @@ -5566,3 +5564,15 @@ def pubsub_shardnumsub( | |||
| ) | |||
|
|
|||
| # TODO: add all CLUSTER commands | |||
|
|
|||
|
|
|||
| @deprecated(reason="Use ClusterBatch(is_atomic=True) instead.") | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe there's a small mistake here: replacement for Transaction should be Batch, not ClusterBatch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. Thanks!!
Issue link
This Pull Request is linked to issue (URL): 3546
Checklist
Before submitting the PR make sure the following are checked: