Skip to content

Conversation

@BoazBD
Copy link
Collaborator

@BoazBD BoazBD commented Apr 7, 2025

Issue link

This Pull Request is linked to issue (URL): 3546

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Create merge commit if merging release branch into main, squash otherwise.

@BoazBD BoazBD requested a review from a team as a code owner April 7, 2025 07:26
@BoazBD BoazBD requested a review from Copilot April 7, 2025 07:26

This comment was marked as off-topic.

@BoazBD BoazBD force-pushed the boaz/pipelines-pythin-python-wrapper branch from d4fb032 to 41dc46b Compare April 7, 2025 07:35
@Yury-Fridlyand Yury-Fridlyand added python 🐍 Python wrapper breaking 💔 breaking changes labels Apr 7, 2025
@Yury-Fridlyand
Copy link

Please don't forget changelog

@BoazBD BoazBD force-pushed the boaz/pipelines-pythin-python-wrapper branch 6 times, most recently from bae1fb6 to 76dda70 Compare April 10, 2025 14:27
@BoazBD BoazBD requested a review from shohamazon April 15, 2025 13:52
@BoazBD BoazBD changed the title Add python pipeline support Python: Add Batch support Apr 20, 2025
Copy link
Collaborator

@shohamazon shohamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job 🚀

@Yury-Fridlyand Yury-Fridlyand mentioned this pull request Apr 23, 2025
22 tasks
BoazBD and others added 9 commits April 28, 2025 14:09
Signed-off-by: BoazBD <boazbd@amazon.com>
Signed-off-by: BoazBD <boazbd@amazon.com>
Signed-off-by: BoazBD <boazbd@amazon.com>
Signed-off-by: BoazBD <boazbd@amazon.com>
Signed-off-by: BoazBD <boazbd@amazon.com>
Signed-off-by: BoazBD <boazbd@amazon.com>
Signed-off-by: BoazBD <boazbd@amazon.com>
Signed-off-by: BoazBD <boazbd@amazon.com>
Signed-off-by: BoazBD <boaz@bardavid.com>
@BoazBD BoazBD force-pushed the boaz/pipelines-pythin-python-wrapper branch from 0fe1f67 to d898b8e Compare April 28, 2025 14:11
@BoazBD BoazBD force-pushed the boaz/pipelines-pythin-python-wrapper branch from 6d40316 to 8e3c30e Compare April 29, 2025 11:30
Signed-off-by: BoazBD <boaz@bardavid.com>
@BoazBD BoazBD force-pushed the boaz/pipelines-pythin-python-wrapper branch from 8e3c30e to 3dbbc48 Compare April 29, 2025 11:34
BoazBD and others added 4 commits April 29, 2025 11:40
Signed-off-by: BoazBD <boaz@bardavid.com>
Signed-off-by: BoazBD <boaz@bardavid.com>
Signed-off-by: BoazBD <boaz@bardavid.com>
Copy link
Collaborator

@shohamazon shohamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌈

@shohamazon shohamazon mentioned this pull request May 4, 2025
6 tasks
@BoazBD BoazBD force-pushed the boaz/pipelines-pythin-python-wrapper branch from 2fa6ba1 to 041bab0 Compare May 5, 2025 07:28
Signed-off-by: BoazBD <boaz@bardavid.com>
@BoazBD BoazBD force-pushed the boaz/pipelines-pythin-python-wrapper branch 4 times, most recently from a995279 to 32b400d Compare May 5, 2025 08:49
Signed-off-by: BoazBD <boaz@bardavid.com>
@BoazBD BoazBD force-pushed the boaz/pipelines-pythin-python-wrapper branch from 32b400d to 93c3e71 Compare May 5, 2025 09:04
Copy link
Collaborator

@shohamazon shohamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AMAZEEEEEE 😮 🔝 ❤️

Signed-off-by: BoazBD <boaz@bardavid.com>
@BoazBD BoazBD force-pushed the boaz/pipelines-pythin-python-wrapper branch from 7cf4f19 to 6473fcc Compare May 5, 2025 11:09
Signed-off-by: BoazBD <boaz@bardavid.com>
@BoazBD BoazBD force-pushed the boaz/pipelines-pythin-python-wrapper branch from 6473fcc to 01419ff Compare May 5, 2025 11:29
Copy link
Collaborator

@shohamazon shohamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌷 🌈 ☁️ 🌃

@mo-amzn mo-amzn self-requested a review May 5, 2025 12:40
@BoazBD BoazBD merged commit 25538ed into valkey-io:main May 5, 2025
24 checks passed
ikolomi pushed a commit that referenced this pull request May 11, 2025
* add python pipeline support

Signed-off-by: BoazBD <boazbd@amazon.com>

* shorten rows for flake8

Signed-off-by: BoazBD <boazbd@amazon.com>

* add transaction timeout test and allign docs with java

Signed-off-by: BoazBD <boazbd@amazon.com>

* fix linters

Signed-off-by: BoazBD <boazbd@amazon.com>

* fix more linters and failed tests

Signed-off-by: BoazBD <boazbd@amazon.com>

* add requirements download to sphinx

Signed-off-by: BoazBD <boazbd@amazon.com>

* allign with lior's url changes

Signed-off-by: BoazBD <boazbd@amazon.com>

* fix imports sort

Signed-off-by: BoazBD <boazbd@amazon.com>

* fix shoham comments 1

Signed-off-by: BoazBD <boaz@bardavid.com>

* fix docs indentation

Signed-off-by: BoazBD <boaz@bardavid.com>

* fix imports sort

Signed-off-by: BoazBD <boaz@bardavid.com>

* install types-Deprecated package

Signed-off-by: BoazBD <boaz@bardavid.com>

* fix indent in docs

Signed-off-by: BoazBD <boaz@bardavid.com>

* small doc fixes

Signed-off-by: BoazBD <boaz@bardavid.com>

* please work

Signed-off-by: BoazBD <boaz@bardavid.com>

* now u must work

Signed-off-by: BoazBD <boaz@bardavid.com>

* helllllp

Signed-off-by: BoazBD <boaz@bardavid.com>

* fix shoham comments 2

Signed-off-by: BoazBD <boaz@bardavid.com>

* fix imports and add route test

Signed-off-by: BoazBD <boaz@bardavid.com>

* fix shoham comments 3

Signed-off-by: BoazBD <boaz@bardavid.com>

* fix mset docs

Signed-off-by: BoazBD <boaz@bardavid.com>

---------

Signed-off-by: BoazBD <boazbd@amazon.com>
Signed-off-by: BoazBD <boaz@bardavid.com>
Co-authored-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>
@@ -5566,3 +5564,15 @@ def pubsub_shardnumsub(
)

# TODO: add all CLUSTER commands


@deprecated(reason="Use ClusterBatch(is_atomic=True) instead.")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe there's a small mistake here: replacement for Transaction should be Batch, not ClusterBatch.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. Thanks!!

@matrey matrey mentioned this pull request May 16, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking 💔 breaking changes python 🐍 Python wrapper

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants