-
Notifications
You must be signed in to change notification settings - Fork 117
C#: batch #3611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C#: batch #3611
Conversation
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
…ction Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
…ction Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
…ction Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
jbrinkman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ![]()
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
…ction Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
jonathanl-bq
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rust changes look good to me for now, but we'll probably need to have our discussion with Avi about validation of pointers. Also, where are the puppy pictures? :P
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* C# transaction Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Refs:
Issue link
This Pull Request is linked to issue (URL): #216 #214
Checklist
Before submitting the PR make sure the following are checked: