Skip to content

Conversation

@Yury-Fridlyand
Copy link

@Yury-Fridlyand Yury-Fridlyand commented Apr 15, 2025

  • Impl
  • Docs
  • Examples
  • Tests
  • Puppy pictures
  • Cleanup debug prints
  • Rename classes or namespace?
  • Linter

Refs:

Issue link

This Pull Request is linked to issue (URL): #216 #214

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Commits will be squashed upon merging.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
…ction

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand Yury-Fridlyand marked this pull request as ready for review April 24, 2025 04:43
@Yury-Fridlyand Yury-Fridlyand requested a review from a team as a code owner April 24, 2025 04:43
@Yury-Fridlyand Yury-Fridlyand changed the title [WIP] C#: transaction [WIP] C#: batch Apr 24, 2025
@Yury-Fridlyand Yury-Fridlyand changed the title [WIP] C#: batch C#: batch Apr 24, 2025
…ction

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
…ction

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Copy link
Collaborator

@jbrinkman jbrinkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
…ction

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Copy link
Collaborator

@jonathanl-bq jonathanl-bq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rust changes look good to me for now, but we'll probably need to have our discussion with Avi about validation of pointers. Also, where are the puppy pictures? :P

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand
Copy link
Author

Also, where are the puppy pictures?

You are the only who read the PR.

There you go

IMG_0276
IMG_0277

@Yury-Fridlyand Yury-Fridlyand merged commit 99ca0a5 into main May 8, 2025
16 checks passed
@Yury-Fridlyand Yury-Fridlyand deleted the csharp/yuryf-transaction branch May 8, 2025 17:13
ikolomi pushed a commit that referenced this pull request May 11, 2025
* C# transaction

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@yipin-chen yipin-chen mentioned this pull request Jul 14, 2025
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C# 🥅 C# wrapper

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants