Changed reference to BrowserModule to CommonModule instead #1503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caused error: `BrowserModule has already been loaded. If you need access to common directives such as NgIf and NgFor from a lazy loaded module, import CommonModule instead.` After trying on lazy loaded app, that had `Ng2BootstrapModule.forRoot()` imported in root App Module.
somombo
changed the title
Hopefully it will pass CI tests now!
Current coverage is 84.94% (diff: 100%)
@@ development #1503 diff @@
=============================================
Files 82 82
Lines 2298 2298
Methods 21 21
Messages 0 0
Branches 296 296
=============================================
Hits 1952 1952
Misses 246 246
Partials 100 100
|
|
Thanks for pointing this out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Importing
BrowserModule(intoSortableModule) Caused error:BrowserModule has already been loaded. If you need access to common directives such as NgIf and NgFor from a lazy loaded module, import CommonModule instead.After trying on lazy loaded app, that had
Ng2BootstrapModule.forRoot()imported in root App Module.ng2-bootstrap Library should not import BrowserModule anywhere.
See NgModule Imports section of Angular Docs for reference