Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed reference to BrowserModule to CommonModule instead #1503

Merged
merged 2 commits into from
Jan 16, 2017
Merged

Changed reference to BrowserModule to CommonModule instead #1503

merged 2 commits into from
Jan 16, 2017

Commits on Jan 16, 2017

  1. Library Modules should not import BrowserModule anywhere 

    Caused error: 
`BrowserModule has already been loaded. If you need access to common directives such as NgIf and NgFor from a lazy loaded module, import CommonModule instead.`

After trying on lazy loaded app, that had `Ng2BootstrapModule.forRoot()` imported in root App Module.
    @somombo
    somombo authored Jan 16, 2017
    Configuration menu
    Copy the full SHA
    449952b View commit details
    Browse the repository at this point in the history

  2. changed code styling to be consistent with the rest 

    Hopefully it will pass CI tests now!
    @somombo
    somombo authored Jan 16, 2017
    Configuration menu
    Copy the full SHA
    fbd402a View commit details
    Browse the repository at this point in the history