feat(tests): add full e2e coverage for Tooltip component #4871

dmitry-zhemchugov · 2018-12-03T13:31:28Z

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

read and followed the CONTRIBUTING.md guide.
built and tested the changes locally.
added/updated tests.
added/updated API documentation.
added/updated demos.

ludmilanesvitiy

Need to move basic testing scope to integration/tooltip_page_spec.ts and full scope of tests to full/tooltip_page_spec.ts
Need to move all logic to PO methods and reuse it in tests
Need to cover each DEMO, according to rule: 1 use-case = 1 describe, 1 step = 1 it
Need to make full coverage for all demos inside component

codecov · 2018-12-03T15:10:29Z

Codecov Report

Merging #4871 into development will decrease coverage by 0.2%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           development    #4871      +/-   ##
===============================================
- Coverage        75.85%   75.65%   -0.21%     
===============================================
  Files              237      237              
  Lines             7336     7336              
  Branches          1464     1464              
===============================================
- Hits              5565     5550      -15     
- Misses            1369     1376       +7     
- Partials           402      410       +8

Impacted Files	Coverage Δ
src/chronos/i18n/it.ts	`71.42% <0%> (-28.58%)`	⬇️
src/chronos/i18n/pl.ts	`72.22% <0%> (-11.12%)`	⬇️
src/chronos/i18n/sk.ts	`82.97% <0%> (-8.52%)`	⬇️
src/chronos/i18n/cs.ts	`86.44% <0%> (-6.78%)`	⬇️
src/chronos/i18n/uk.ts	`78.04% <0%> (-2.44%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1662554...7c5e5d2. Read the comment docs.

codecov · 2018-12-03T15:10:29Z

Codecov Report

Merging #4871 into development will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           development    #4871   +/-   ##
============================================
  Coverage        74.78%   74.78%           
============================================
  Files              281      281           
  Lines             8547     8547           
  Branches          1631     1631           
============================================
  Hits              6392     6392           
  Misses            1705     1705           
  Partials           450      450

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e77f25...99c24a8. Read the comment docs.

package-lock.json

cypress/full/tooltip_page_spec.ts

ludmilanesvitiy · 2018-12-21T10:53:10Z

cypress/support/tooltip.po.ts

+
+  isTooltipAppearOnFocus(baseSelector: string) {
+    cy.get(`${baseSelector} ${this.togglerTooltip}`).focus();
+    this.isTooltipAppearsAndVisible(baseSelector);


isTooltipAppearOnFocus => make just method focusOnTooltip(baseSelector, additionalSelector?:string)

ludmilanesvitiy · 2018-12-21T10:54:14Z

cypress/support/tooltip.po.ts

+
+  };
+
+  placementsOfTheTooltipContainer = {


tooltipPlacements

ludmilanesvitiy · 2018-12-21T10:54:38Z

cypress/support/tooltip.po.ts

+  };
+
+  placementsOfTheTooltipContainer = {
+    placementTop: { tooltipContainerClass: 'tooltip in tooltip-top bs-tooltip-top top show', name: 'Tooltip on top' },


top:
right:
auto:
left:
bottom:

ludmilanesvitiy · 2018-12-21T11:40:52Z

cypress/support/tooltip.po.ts

+    cy.get(`${baseSelector} ${this.togglerTooltip}`).focus();
+    this.isTooltipAppearsAndVisible(this.body);
+    }
+  isCustomTriggersClickAppearsAndVisible(baseSelector: string, buttonName: string, tiggerEvent: string, tooltipText: string) {


not descriptive name

cypress/support/tooltip.po.ts

ludmilanesvitiy · 2018-12-21T11:42:48Z

cypress/support/tooltip.po.ts

+    cy.get(`${baseSelector}`).should('to.have.descendants', this.containerTooltip);
+    cy.get(`${this.containerTooltip}`).should('be.visible').contains(tooltipText);
+    cy.get(`${baseSelector}`).contains('Toggle').click();
+    cy.get(`${baseSelector}`).should('not.to.have.descendants', this.containerTooltip);


need rework according to the previous comment

ludmilanesvitiy · 2018-12-21T11:43:29Z

cypress/support/tooltip.po.ts

+  }
+  clickOnDemoMenu(subMenu: string) {
+    cy.get('add-nav').contains('a', subMenu).click();
+  }


need to remove it and reuse method from base component

ludmilanesvitiy · 2019-01-11T11:51:42Z

cypress/full/tooltip_page_spec.ts

+
+  describe('Placement tooltip', () => {
+
+    const basic = tooltip.exampleDemosArr.placement;


const basic => const placementDemo

ludmilanesvitiy · 2019-01-11T12:00:10Z

cypress/full/tooltip_page_spec.ts

+
+  describe('Dismiss tooltip', () => {
+
+    const dismissPlacement = tooltip.exampleDemosArr.dismiss;


const dismissPlacement => const dismiss or const dismissDemo

ludmilanesvitiy · 2019-01-11T12:03:05Z

cypress/full/tooltip_page_spec.ts

+
+  describe('Dynamic Content', () => {
+
+    const dynamicContentPlacement = tooltip.exampleDemosArr.dynamicTooltip;


dynamicContent

ludmilanesvitiy · 2019-01-11T12:04:30Z

cypress/full/tooltip_page_spec.ts

+    const basic = tooltip.exampleDemosArr.placement;
+    const placement = tooltip.tooltipPlacements;
+
+    it('when user on hovering on trigger btn in the Placement exmpl - tooltip appears on the setted placement', () => {


when user hover on Trigger btn

ludmilanesvitiy · 2019-01-11T12:07:19Z

cypress/full/tooltip_page_spec.ts

+    const dynamicContentPlacement = tooltip.exampleDemosArr.dynamicTooltip;
+
+    it('when user clicks on the Dynamic Content tooltip btn, Tooltip appears', () => {
+      tooltip.focusOnTooltip(dynamicContentPlacement);


clickOnTooltip

ludmilanesvitiy · 2019-01-11T12:09:21Z

cypress/support/tooltip.po.ts

+    dismiss: 'demo-tooltip-dismiss',
+    dynamicTooltip: 'demo-tooltip-dynamic',
+    customContentTemplate: 'demo-tooltip-custom-content',
+    dynamicHtmlButton: 'demo-tooltip-dynamic-html',


dynamicHtml

just dynamicHtml

ludmilanesvitiy · 2019-01-11T12:15:17Z

cypress/support/tooltip.po.ts

+    dynamicTooltip: 'demo-tooltip-dynamic',
+    customContentTemplate: 'demo-tooltip-custom-content',
+    dynamicHtmlButton: 'demo-tooltip-dynamic-html',
+    defaultTooltip: 'demo-tooltip-container',


appendToBody

ludmilanesvitiy · 2019-01-11T12:16:27Z

cypress/full/tooltip_page_spec.ts

+    const configuringDefaultsTooltip = tooltip.exampleDemosArr.configuringDefaults;
+
+    it('when user clicks on the Configuring tooltip btn, Tooltip appears & dismiss after mouse leave', () => {
+      tooltip.focusOnTooltip(configuringDefaultsTooltip);


ludmilanesvitiy · 2019-01-11T12:21:59Z

cypress/integration/tooltip_page_spec.ts

-      cy.get(basic).as('basicDemo').find(tooltip.togglerTooltip).focus();
-      cy.get('@basicDemo')
-        .should('to.have.descendants', tooltip.containerTooltip);
+    it('when the user on hovering on the trigger btn, tooltip appears and dismiss after mouse leave', () => {


...user hover on the trigger btn...

ludmilanesvitiy · 2019-01-11T12:31:01Z

cypress/support/tooltip.po.ts

+  }
+  clickOnDemoMenu(subMenu: string) {
+    cy.get('add-nav').contains('a', subMenu).click();
+  }


need to remove it and reuse method from base component

ludmilanesvitiy · 2019-01-15T11:58:54Z

cypress/full/tooltip_page_spec.ts

+  describe('Configuring defaults', () => {
+    const configuringDefaults = tooltip.exampleDemosArr.configuringDefaults;
+
+    it('when user clicks on the Configuring tooltip btn, Tooltip appears & dismiss after mouse leave', () => {


& dismiss after mouse leave - looks like need to remove it

ludmilanesvitiy · 2019-01-15T12:24:19Z

cypress/support/tooltip.po.ts

+    dismiss: 'demo-tooltip-dismiss',
+    dynamicTooltip: 'demo-tooltip-dynamic',
+    customContentTemplate: 'demo-tooltip-custom-content',
+    dynamicHtmlButton: 'demo-tooltip-dynamic-html',


just dynamicHtml

ludmilanesvitiy · 2019-01-15T12:24:33Z

cypress/support/tooltip.po.ts

+    dynamicTooltip: 'demo-tooltip-dynamic',
+    customContentTemplate: 'demo-tooltip-custom-content',
+    dynamicHtmlButton: 'demo-tooltip-dynamic-html',
+    defaultTooltip: 'demo-tooltip-container',


appendToBody

ludmilanesvitiy · 2019-01-15T12:25:35Z

cypress/support/tooltip.po.ts

+  }
+  clickOnDemoMenu(subMenu: string) {
+    cy.get('add-nav').contains('a', subMenu).click();
+  }


need to remove it and reuse method from base component

valorkin · 2019-02-06T15:26:47Z

@dmitry-zhemchugov use commit convention properly
it's tests(tooltip) not feat(tests)

dmitry-zhemchugov · 2019-02-07T03:01:15Z

via Hubstaff
User: Dmitry Zhemchugov

Project: int_ngx-bootstrap (OSS) - https://app.hubstaff.com/projects/304822
Date Range: 01/16/19 - 01/16/19
Work session total: 0:00:10

Grand total: 0:00:10

…ftware#4871)

ghost added the needs review label Dec 3, 2018

ludmilanesvitiy suggested changes Dec 3, 2018

View reviewed changes

ludmilanesvitiy added enhancement comp(tooltip) needs fix and removed needs review labels Dec 3, 2018

dmitry-zhemchugov force-pushed the e2e-tests-tooltip branch from 7c5e5d2 to b761c36 Compare December 20, 2018 16:57

ghost added needs review and removed needs fix labels Dec 20, 2018

dmitry-zhemchugov force-pushed the e2e-tests-tooltip branch 3 times, most recently from 3f35e15 to 3fe3dc9 Compare December 20, 2018 17:15

ludmilanesvitiy suggested changes Dec 21, 2018

View reviewed changes

ludmilanesvitiy changed the title ~~tests(tooltip): added e2e test for tooltip~~ feat(tests): add full e2e coverage for Tooltip component Dec 21, 2018

ludmilanesvitiy added needs fix and removed needs review labels Dec 21, 2018

dmitry-zhemchugov force-pushed the e2e-tests-tooltip branch from 3fe3dc9 to 7197cec Compare December 21, 2018 17:46

ghost added needs review and removed needs fix labels Dec 21, 2018

dmitry-zhemchugov force-pushed the e2e-tests-tooltip branch 5 times, most recently from 167cee9 to 8a118f9 Compare January 3, 2019 13:38

ludmilanesvitiy suggested changes Jan 11, 2019

View reviewed changes

ludmilanesvitiy assigned dmitry-zhemchugov Jan 11, 2019

ludmilanesvitiy mentioned this pull request Jan 11, 2019

feat(tests): add full e2e coverage for Popover component #5001

Merged

5 tasks

dmitry-zhemchugov force-pushed the e2e-tests-tooltip branch from 8a118f9 to 4317cad Compare January 11, 2019 16:29

dmitry-zhemchugov force-pushed the e2e-tests-tooltip branch 5 times, most recently from 51338c5 to 5f3a11b Compare January 15, 2019 11:28

ludmilanesvitiy reviewed Jan 15, 2019

View reviewed changes

feat(tests): add full e2e coverage for Tooltip component

0b11ed2

dmitry-zhemchugov force-pushed the e2e-tests-tooltip branch from 5f3a11b to 0b11ed2 Compare January 15, 2019 12:41

ludmilanesvitiy approved these changes Jan 15, 2019

View reviewed changes

ludmilanesvitiy added ready for merge and removed needs review labels Jan 15, 2019

valorkin approved these changes Feb 5, 2019

View reviewed changes

valorkin added this to the 3.2.1 milestone Feb 5, 2019

Merge branch 'development' into e2e-tests-tooltip

99c24a8

ghost assigned ludmilanesvitiy Feb 5, 2019

valorkin approved these changes Feb 6, 2019

View reviewed changes

valorkin merged commit c0c5ee2 into valor-software:development Feb 6, 2019

ghost removed the ready for merge label Feb 6, 2019

leo6104 pushed a commit to leo6104/ngx-bootstrap that referenced this pull request Oct 10, 2019

tests(tooltip): add full e2e coverage for Tooltip component (valor-so…

3ebafb6

…ftware#4871)

IraErshova pushed a commit to IraErshova/ngx-bootstrap that referenced this pull request Jan 20, 2020

tests(tooltip): add full e2e coverage for Tooltip component (valor-so…

41aa1fa

…ftware#4871)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(tests): add full e2e coverage for Tooltip component #4871

feat(tests): add full e2e coverage for Tooltip component #4871

dmitry-zhemchugov commented Dec 3, 2018

ludmilanesvitiy left a comment •

edited

Loading

codecov bot commented Dec 3, 2018

codecov bot commented Dec 3, 2018 •

edited

Loading

ludmilanesvitiy Dec 21, 2018

ludmilanesvitiy Dec 21, 2018

ludmilanesvitiy Dec 21, 2018

ludmilanesvitiy Dec 21, 2018

ludmilanesvitiy Dec 21, 2018

ludmilanesvitiy Dec 21, 2018

ludmilanesvitiy Jan 11, 2019

ludmilanesvitiy Jan 15, 2019

ludmilanesvitiy Jan 11, 2019

ludmilanesvitiy Jan 11, 2019

ludmilanesvitiy Jan 11, 2019

ludmilanesvitiy Jan 11, 2019

ludmilanesvitiy Jan 11, 2019

ludmilanesvitiy Jan 11, 2019

ludmilanesvitiy Jan 15, 2019

ludmilanesvitiy Jan 11, 2019

ludmilanesvitiy Jan 15, 2019

ludmilanesvitiy Jan 11, 2019

ludmilanesvitiy Jan 11, 2019

ludmilanesvitiy Jan 11, 2019

ludmilanesvitiy Jan 15, 2019

ludmilanesvitiy Jan 15, 2019

ludmilanesvitiy Jan 15, 2019

ludmilanesvitiy Jan 15, 2019

valorkin commented Feb 6, 2019

dmitry-zhemchugov commented Feb 7, 2019


		describe('Placement tooltip', () => {

		const basic = tooltip.exampleDemosArr.placement;


		describe('Dismiss tooltip', () => {

		const dismissPlacement = tooltip.exampleDemosArr.dismiss;


		describe('Dynamic Content', () => {

		const dynamicContentPlacement = tooltip.exampleDemosArr.dynamicTooltip;

feat(tests): add full e2e coverage for Tooltip component #4871

feat(tests): add full e2e coverage for Tooltip component #4871

Conversation

dmitry-zhemchugov commented Dec 3, 2018

PR Checklist

ludmilanesvitiy left a comment • edited Loading

Choose a reason for hiding this comment

codecov bot commented Dec 3, 2018

Codecov Report

codecov bot commented Dec 3, 2018 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

valorkin commented Feb 6, 2019

dmitry-zhemchugov commented Feb 7, 2019

ludmilanesvitiy left a comment •

edited

Loading

codecov bot commented Dec 3, 2018 •

edited

Loading