feat(tests): add full e2e coverage for Popover component #5001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Codecov Report
@@ Coverage Diff @@
## development #5001 +/- ##
===============================================
+ Coverage 74.79% 74.81% +0.01%
===============================================
Files 277 277
Lines 8436 8436
Branches 1603 1603
===============================================
+ Hits 6310 6311 +1
+ Misses 1680 1677 -3
- Partials 446 448 +2
Continue to review full report at Codecov.
|
dmitry-zhemchugov
force-pushed
the
e2e-tests-popover
branch
from
54fce07 to
276ac1b
Compare
|
@dmitry-zhemchugov All PR labels, reviewers, assignees should be similar to #4871 |
ludmilanesvitiy
suggested changes
Jan 11, 2019
cypress/full/popover_page_spec.ts
Outdated
|
|
||
| describe('Placement popover', () => { | ||
|
|
||
| const basic = popover.exampleDemosArr.placement; |
cypress/support/base.component.ts
Outdated
| @@ -55,6 +55,18 @@ export abstract class BaseComponent { | |||
| cy.get(`${ baseSelector } input`).eq(inputIndex ? inputIndex : 0).dblclick(); | |||
| } | |||
|
|
|||
| typeOnInput(baseSelector: string, forInput: string, inputIndex?: number) { | |||
There was a problem hiding this comment.
same as clearInputAndSendKeys method, in this class
cypress/support/popover.po.ts
Outdated
| dynamicHtml: 'demo-popover-dynamic-html', | ||
| appendToBody: 'demo-popover-container', | ||
| visibilityEvents: 'demo-popover-events', | ||
| eventTextBlock: 'pre.card.card-block.card-header.mb-3', |
There was a problem hiding this comment.
- bad selector, need to find more stable
- it should be not in the exampleDemosArr
cypress/support/popover.po.ts
Outdated
| cy.get(`${baseSelector}`).should('not.to.have.descendants', this.containerPopover); | ||
| } | ||
|
|
||
| isEventShown(baseSelector1: string) { |
There was a problem hiding this comment.
what does it mean baseSelector1 ?
cypress/support/popover.po.ts
Outdated
| cy.get(`${baseSelector1}`).contains('shown'); | ||
| } | ||
|
|
||
| isEventHidden(baseSelector1: string) { |
There was a problem hiding this comment.
what does it mean baseSelector1 ?
dmitry-zhemchugov
force-pushed
the
e2e-tests-popover
branch
from
276ac1b to
5244ee7
Compare
cypress/full/popover_page_spec.ts
Outdated
| }); | ||
|
|
||
| it('when user clicks on "Preconfigured popover" again, nothing happens', () => { | ||
| popover.clickOnBtn(configuringDefaults); |
| const popover = new PopoverPo(); | ||
|
|
||
| beforeEach(() => popover.navigateTo()); | ||
| before(() => popover.navigateTo()); |
dmitry-zhemchugov
force-pushed
the
e2e-tests-popover
branch
from
5244ee7 to
a34bfd5
Compare
valorkin
approved these changes
Jan 14, 2019
leo6104
pushed a commit
to leo6104/ngx-bootstrap
that referenced
this pull request
Oct 10, 2019
IraErshova
pushed a commit
to IraErshova/ngx-bootstrap
that referenced
this pull request
Jan 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.