ACN service registry address

[Karrenbelt]

Proposed changes

Working on the extended RegistrationStartupBehaviour behavior and associated e2e tests.

Currently managed to:

• introduce new agent registration_start_up for testing specifically the RegistrationStartupBehaviour
• retrieve service info (e.g. registered addresses) from ServiceRegistry contract deployed on our staging chain.
  NOTE: addresses do not exactly match those of agents: one-off still.
• exchange messages (tendermint_url) using Tendermint protocol via ACN client connection to ACN node (registration_start_up/aea-config.yaml).
• 4 agent system running, no more deadlock and connecting to the same ACN port (per aea-config.yaml)
• 4 agent system with catchup: other agents not crashing anymore

Noteworthy changes:

• service registry contract: verify_contract was validation against outdated bytecode. Now returning True by default to accommodate changes in our online protocol without having to continuously update this, added an error messages to logger to indicate as much
• removed the deadlocking yield.
• removed callback functionality for Tendermint config sharing request / response handler.

TODO:

• sort out agent addresses misalignment in tests and service registry (not sure why still there - off by one)
• include Tendermint server (via image being developed here Create a test case for Tendermint e2e tests #781), then make required calls: request, update, restart.

dependencies added:

    connections/valory/p2p_libp2p_client:0.1.0
    contracts/valory/service_registry:0.1.0 
    protocols/valory/acn:1.1.0
    protocols/valory/tendermint:0.1.0

NOTES:

• valory/contracts/service_registry is already here in the consensus repo.
• TestTendermintHandler and TestRegistrationStartupBehaviour tests fail because these were changed, please ignore.
• altered agent termination logic in BaseTestEnd2EndNormalExecution and BaseTestEnd2EndAgentCatchup. No agent terminates before the entire test is ran (otherwise leads to failures in BaseTestEnd2EndAgentCatchup tests
• now terminating process (agent) instead of only popping from the list (cause other agents to crash with some regularity)

Please see comments in #760

Fixes

If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.)
Put an x in the box that applies

• Non-breaking fix (non-breaking change which fixes an issue)
• Breaking fix (breaking change which fixes an issue)
• Non-breaking feature (non-breaking change which adds functionality)
• Breaking feature (breaking change which adds functionality)
• Refactor (non-breaking change which changes implementation)
• Messy (mixture of the above - requires explanation!)

Checklist

Put an x in the boxes that apply.

• I have read the CONTRIBUTING doc
• I am making a pull request against the main branch (left side). Also you should start your branch off our main.
• Lint and unit tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

[codecov]

Codecov Report

Merging #680 (60a4e38) into main (e796833) will decrease coverage by 0.71%.
The diff coverage is 100.00%.

❗ Current head 60a4e38 differs from pull request most recent head e811c4f. Consider uploading reports for the commit e811c4f to get more accurate results

@@            Coverage Diff             @@
##             main     #680      +/-   ##
==========================================
- Coverage   97.91%   97.20%   -0.72%     
==========================================
  Files         250      229      -21     
  Lines       14121    13712     -409     
==========================================
- Hits        13827    13329     -498     
- Misses        294      383      +89     

Flag	Coverage Δ
unittests	97.20% <100.00%> (-0.72%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
packages/valory/protocols/abci/__init__.py	100.00% <ø> (ø)
packages/valory/protocols/contract_api/__init__.py	100.00% <ø> (ø)
packages/valory/protocols/http/__init__.py	100.00% <ø> (ø)
packages/valory/protocols/ledger_api/__init__.py	100.00% <ø> (ø)
...ges/valory/skills/abstract_round_abci/dialogues.py	100.00% <100.00%> (ø)
...ages/valory/skills/abstract_round_abci/handlers.py	100.00% <100.00%> (ø)
...ckages/valory/skills/abstract_round_abci/models.py	100.00% <100.00%> (ø)
...ages/valory/skills/apy_estimation_abci/handlers.py	100.00% <100.00%> (ø)
...ory/skills/apy_estimation_chained_abci/handlers.py	100.00% <100.00%> (ø)
...valory/skills/liquidity_provision_abci/handlers.py	100.00% <100.00%> (ø)
... and 73 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e4f17a...e811c4f. Read the comment docs.

[DavidMinarsch]

It's indeed not ideal that we have to run the connection just because we load it. For now there's no way around it. But you can open an issue on open-aea to consider adding an "is_abstract" mode for connections too! (We already have it for skills.)

[DavidMinarsch]

Why?

[Karrenbelt]

why yield from super().async_act()? This might not be necessary, but I don't see no harm either. It will create the first payload and ensures that all agents reached consensus on the initial data (which now includes the tendermint config). I suppose you want me to remove the yield from super().async_act() ?

[angrybayblade]

I tried running a local deployment but I got this

  File "/usr/lib/python3.10/hashlib.py", line 123, in __get_builtin_constructor
    raise ValueError('unsupported hash type ' + name)
ValueError: unsupported hash type ripemd160
AEA key provided. Copying to agent.
Usage: aea add-key [OPTIONS] TYPE FILE
Try 'aea add-key --help' for help.

Error: Invalid value: File 'cosmos_private_key.txt' does not exist.
Failed to add cosmos key needed for libp2p connection

[Adamantios]

I tried running a local deployment but I got this

  File "/usr/lib/python3.10/hashlib.py", line 123, in __get_builtin_constructor
    raise ValueError('unsupported hash type ' + name)
ValueError: unsupported hash type ripemd160
AEA key provided. Copying to agent.
Usage: aea add-key [OPTIONS] TYPE FILE
Try 'aea add-key --help' for help.

Error: Invalid value: File 'cosmos_private_key.txt' does not exist.
Failed to add cosmos key needed for libp2p connection

You also need to run:

autonomy generate-key cosmos cosmos_private_key.txt
autonomy add-key cosmos cosmos_private_key.txt
autonomy issue-certificates

[angrybayblade]

You also need to run:

autonomy generate-key cosmos cosmos_private_key.txt
autonomy add-key cosmos cosmos_private_key.txt
autonomy issue-certificates

The error occurs while running autonomy generate-key cosmos cosmos_private_key.txt

[Adamantios]

Windows 3.7 and 3.10 tests failed on last run because of network failure:

wget not installed. An error occurred during installation:
 The remote server returned an error: (500) Internal Server Error. Internal Server Error
wget package files install failed with exit code 1. Performing other installation steps.
The install of wget was NOT successful.

I will rerun them later.

Macos test failed because of #989.