Update trader_pearl service #381
Open
+64
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release `v0.21.4`
Release `v0.22.0`
jmoreira-valory
force-pushed
the
chore/update_pearl_service
branch
from
7302ced to
d9cfdbd
Compare
jmoreira-valory
commented
Jan 7, 2025
| @@ -92,10 +99,10 @@ models: | |||
| "token_address":"0x1b5DeaD7309b56ca7663b3301A503e077Be18cba", "order_address":"0x72201948087aE83f8Eac22cf7A9f2139e4cFA829", | |||
| "nft_amount":"100", "payment_token":"0x0000000000000000000000000000000000000000", | |||
| "price":"1000000000000000000"}} | |||
There was a problem hiding this comment.
@Adamantios @0xArdi to verify if mech_to_subscription_params is correct. Currently used in mainstream Pearl is on #344
There was a problem hiding this comment.
The values are not the same, e.g.:
I guess the latest ones are the correct ones. In any case, it does not matter because they can be overridden. Moreover, the marketplace is not used, unless you plan to enable it on Pearl.
Adamantios
previously approved these changes
Jan 8, 2025
jmoreira-valory
had a problem deploying
to
production
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update trader_pearl service