Chore: Update trader_pearl #388
Open
+248
−108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adamantios
reviewed
Jan 17, 2025
There was a problem hiding this comment.
This is even closer to what I suggested in #381 (review). Cannot we just delete this service definition?
Indeed the idea is to eventually delete it. We are working to make it converge to the 'normal' trader. We can't do it right now due to some technical reasons on Pearl: to update a service we require it has the SAME public ID (this will fail if we suddently replace trader_pearl by trader). We'll investigate how to solve that. |
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
OjusWiZard
force-pushed
the
chore/bump-trader_pearl
branch
from
89c8ff4 to
efcc6ad
Compare
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.