Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3 header fixes #1088

Merged
merged 3 commits into from
Jan 3, 2025
Merged

V3 header fixes #1088

merged 3 commits into from
Jan 3, 2025

Conversation

idamand
Copy link
Contributor

@idamand idamand commented Jan 2, 2025

Fixes several issues with the header, especially on mobile/tablet:

  • The mobile/tablet header no longer removes the padding in body when opened
  • The clickable area on the header links in mobile/tablet is now using 100% of the width making the area larger
  • When a user is on the english version of the site, they no longer end up on the norwegian landing page when clicking the logo in the header

Before

Screenshot 2025-01-02 at 10 37 23

After

Screenshot 2025-01-02 at 10 37 03

Closes #1087

Copy link

vercel bot commented Jan 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
variant-no ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 9:57am
variant-se-2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 9:57am

@@ -163,7 +163,7 @@ html {

body {
margin: 0;
padding: 0 1rem;
padding: 0 1rem !important;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Burde nok prøve å unngå important. Ser at det er satt en del important på body[data-scroll-locked]. Mulig dette kan være grunnen til at man trenger important her?🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Klarer ikke finne noe css for det. Ser ikke ut som det er noe vi har lagt til

Copy link
Contributor

@TrymVei TrymVei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ser bra ut. Eneste jeg er litt usikker på er det med !important. Regner med at width på linker er satt til 100% for å gjøre det lettere å klikke på

@idamand idamand merged commit 3a24374 into v3 Jan 3, 2025
6 checks passed
@idamand idamand deleted the v3-header-fixes branch January 3, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Header removes padding when opened on mobile
2 participants