Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3 header fixes #1088

Merged
merged 3 commits into from
Jan 3, 2025
Merged

V3 header fixes #1088

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d7ac308
Fix issue where opening the mobile menu removed padding in body due t…
idamand Jan 2, 2025
4120fcb
Fix issue where where the Variant logo always led to the defualt lang…
idamand Jan 2, 2025
7f9ba45
Make entire width of mobile menu links clickable
idamand Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/components/link/link.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,7 @@

.headerLink {
white-space: nowrap;
width: 100%;
color: var(--text-primary);
cursor: pointer;
text-decoration: none;
Expand All @@ -149,7 +150,7 @@
font-weight: 500;
display: inline-flex;
padding: 0.75rem 1rem 0.75rem 0.75rem;
justify-content: center;
justify-content: flex-start;
align-items: center;
gap: 0.375rem;
position: relative;
Expand Down
2 changes: 1 addition & 1 deletion src/components/navigation/header/Header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ export const Header = ({
<div className={styles.wrapper}>
<div className={styles.desktopWrapper}>
<Link
href="/"
href={`/${currentLanguage}`}
aria-label="Home"
className={styles.logo}
scroll={false}
Expand Down
2 changes: 1 addition & 1 deletion src/styles/global.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ html {

body {
margin: 0;
padding: 0 1rem;
padding: 0 1rem !important;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Burde nok prøve å unngå important. Ser at det er satt en del important på body[data-scroll-locked]. Mulig dette kan være grunnen til at man trenger important her?🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Klarer ikke finne noe css for det. Ser ikke ut som det er noe vi har lagt til

color: var(--text-primary);
background-color: var(--background-bg-light-primary);
font-family: var(--font-britti-sans);
Expand Down
Loading