Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved NotAuthorizedError message when record is a class #647

Closed
wants to merge 1 commit into from
Closed

Improved NotAuthorizedError message when record is a class #647

wants to merge 1 commit into from

Commits on Mar 12, 2020

  1. Better error message if authorize passed a Class 

    In some cases you may want to authorize actions against a class not an
instance of that class. If authorization fails when a class is passed to
authorize the error message is unhelpful. For example

    not allowed to index? Class

This PR checks if an instance or class was passed and provides more
informative error message in the case of a class. The error
message for an instance being passed remains the same.

For a concrete example of class being passed see jsonapi-authorization
https://github.com/venuu/jsonapi-authorization/blob/3251c6589d31bc931ee3a98c5c47e16eedd82b97/lib/jsonapi/authorization/default_pundit_authorizer.rb#L28-L31
    @mrloop
    mrloop committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    03d01bb View commit details
    Browse the repository at this point in the history