Improved NotAuthorizedError message when record is a class

lib/pundit.rb

@@ -33,7 +33,13 @@ def initialize(options = {})
         @policy = options[:policy]
         @reason = options[:reason]
 
-        message = options.fetch(:message) { "not allowed to #{query} this #{record.class}" }
+        name = if record.is_a?(Class)
+          record.name
+        else
+          "this #{record.class.name}"
+        end
+
+        message = options.fetch(:message) { "not allowed to #{query} #{name}" }
       end
 
       super(message)

spec/pundit_spec.rb

@@ -484,6 +484,16 @@
     it "raises an error with a invalid policy constructor" do
       expect { controller.authorize(wiki, :destroy?) }.to raise_error(Pundit::InvalidConstructorError)
     end
+
+    it "raises an error with class name when passed Class" do
+      expect { controller.authorize(Post, :index?) }
+        .to raise_error(Pundit::NotAuthorizedError, "not allowed to index? Post")
+    end
+
+    it "raises an error with class name when passed record" do
+      expect { controller.authorize(post, :destroy?) }
+        .to raise_error(Pundit::NotAuthorizedError, "not allowed to destroy? this Post")
+    end
   end
 
   describe "#skip_authorization" do

spec/spec_helper.rb

@@ -35,6 +35,10 @@ def show?
     true
   end
 
+  def index?
+    false
+  end
+
   def permitted_attributes
     if post.user == user
       %i[title votes]