Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the side panel to a console window. #150

Closed
BoPeng opened this issue Dec 2, 2018 · 21 comments
Closed

Change the side panel to a console window. #150

BoPeng opened this issue Dec 2, 2018 · 21 comments
Assignees
Labels

Comments

@BoPeng
Copy link
Contributor

BoPeng commented Dec 2, 2018

With long discussions on the JupyterLab side, it is becoming clear that the side panel and related features will be implemented in JLab console window. That is to say, the console window

  1. will be destination of line by line execution (the runInConsole feature)
  2. will be used to display transient_display_data (the transient_message plugin)

It is hard to say which interface is better but the console window has the advantage of saving all histories, which will fix #143 because the output of the preview magic will not overwrite the error message from previous statement.

@BoPeng
Copy link
Contributor Author

BoPeng commented Dec 5, 2018

Work in progress:

image

BoPeng pushed a commit that referenced this issue Dec 5, 2018
@BoPeng
Copy link
Contributor Author

BoPeng commented Dec 5, 2018

@gaow @HenryLeongStat

Still need to fix execution counter and perhaps other stuff, but let me know how you think of this new side panel. It resembles the console window of JupyterLab.

BoPeng pushed a commit that referenced this issue Dec 5, 2018
BoPeng pushed a commit that referenced this issue Dec 5, 2018
BoPeng pushed a commit that referenced this issue Dec 5, 2018
BoPeng pushed a commit that referenced this issue Dec 5, 2018
BoPeng pushed a commit that referenced this issue Dec 5, 2018
BoPeng pushed a commit that referenced this issue Dec 6, 2018
BoPeng pushed a commit that referenced this issue Dec 6, 2018
BoPeng pushed a commit that referenced this issue Dec 6, 2018
BoPeng pushed a commit that referenced this issue Dec 6, 2018
BoPeng pushed a commit that referenced this issue Dec 6, 2018
@HenryLeongStat
Copy link
Member

Liking it on my end!!

When I expand the cell, the color and the little triangle don't expand when the size of the cell reaches to a certain size.

screen shot 2018-12-06 at 10 36 09 am

@BoPeng
Copy link
Contributor Author

BoPeng commented Dec 6, 2018

Cannot reproduce. There is a maximum of 1/2 width of the side panel but I do not see the triangle goes into the middle. I am still tweaking, perhaps you are not at the latest trunk? Note that you need to do python -m sos_notebook.install restart the browser after pip install . -U.

image

@HenryLeongStat
Copy link
Member

The problem begins to show up when you have some history above and the scrollbar shows up:

screen shot 2018-12-06 at 11 13 54 am

screen shot 2018-12-06 at 11 13 41 am

@gaow
Copy link
Member

gaow commented Dec 6, 2018

@BoPeng I'm mostly on JupyterLab these days for SoS Notebook. Maybe missing some of the nice new developments here. But when i was just trying to reproduce @HenryLeongStat 's issue I noticed the side-panel can be dragged out of the embedded page and become floating again and cannot be easily restored. ...

@BoPeng
Copy link
Contributor Author

BoPeng commented Dec 6, 2018

I disabled dragging yesterday, how did you drag?

@gaow
Copy link
Member

gaow commented Dec 6, 2018

I pulled the latest master, hovered over the side panel, and dragged by moving my mouse to the light yellow region on the top of the side panel:

2018-12-06-11-25-31_scrot

@HenryLeongStat
Copy link
Member

Interesting... I can't drag the side panel.

BoPeng pushed a commit that referenced this issue Dec 6, 2018
@BoPeng
Copy link
Contributor Author

BoPeng commented Dec 6, 2018

@gaow I believe that you forgot to do python -m sos_notebook.install because the screenshot is not the master.

@BoPeng
Copy link
Contributor Author

BoPeng commented Dec 6, 2018

I can now reproduce the middle triangle thing.

@BoPeng
Copy link
Contributor Author

BoPeng commented Dec 6, 2018

I think I will just remove the triangle because it is not usable.

@gaow
Copy link
Member

gaow commented Dec 6, 2018

I have a local Makefile that always does python -m sos_notebook.install. Let me see what is going on here ...

@HenryLeongStat
Copy link
Member

Exactly! Expanding the side panel doesn't need the triangle. For the color along with the code cell, it still looks good even it doesn't expand along with the code cell.

But for the history above, maybe better to change the color of the background of the code?

screen shot 2018-12-06 at 11 55 53 am

BoPeng pushed a commit that referenced this issue Dec 6, 2018
@BoPeng
Copy link
Contributor Author

BoPeng commented Dec 6, 2018

OK. Input background is restored, but the output zigzag (#153) remains. Checking if there is anyway to fix it.

BoPeng pushed a commit that referenced this issue Dec 6, 2018
@HenryLeongStat
Copy link
Member

Looking good!!
screen shot 2018-12-06 at 3 35 06 pm

@HenryLeongStat
Copy link
Member

HenryLeongStat commented Dec 6, 2018

How about making the color of the "In [1]" rectangle small for solving the zigzag?

@BoPeng
Copy link
Contributor Author

BoPeng commented Dec 6, 2018

What do you mean?

@HenryLeongStat
Copy link
Member

For example, the zigzag below is like

screen shot 2018-12-06 at 3 41 30 pm

screen shot 2018-12-06 at 3 43 29 pm

Is there a way to make the blue rectangle smaller? Or, changing yellow to transplant?

@BoPeng
Copy link
Contributor Author

BoPeng commented Dec 6, 2018

I have tried... The problem seems to be the because the output prompt was always clear, they did not bother to make input and output prompt exactly the same size. Instead, the output prompt was made a bit wider to indent the output.

@HenryLeongStat
Copy link
Member

I see... And I see the reason why you changed the color of the background of the code in history of the side panel into the same color as the "blue" rectangle.

@BoPeng BoPeng closed this as completed Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants