-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the side panel to a console window. #150
Comments
Still need to fix execution counter and perhaps other stuff, but let me know how you think of this new side panel. It resembles the console window of JupyterLab. |
@BoPeng I'm mostly on JupyterLab these days for SoS Notebook. Maybe missing some of the nice new developments here. But when i was just trying to reproduce @HenryLeongStat 's issue I noticed the side-panel can be dragged out of the embedded page and become floating again and cannot be easily restored. ... |
I disabled dragging yesterday, how did you drag? |
Interesting... I can't drag the side panel. |
@gaow I believe that you forgot to do |
I can now reproduce the middle triangle thing. |
I think I will just remove the triangle because it is not usable. |
I have a local Makefile that always does |
OK. Input background is restored, but the output zigzag (#153) remains. Checking if there is anyway to fix it. |
How about making the color of the "In [1]" rectangle small for solving the zigzag? |
What do you mean? |
I have tried... The problem seems to be the because the output prompt was always clear, they did not bother to make input and output prompt exactly the same size. Instead, the output prompt was made a bit wider to indent the output. |
I see... And I see the reason why you changed the color of the background of the code in history of the side panel into the same color as the "blue" rectangle. |
With long discussions on the JupyterLab side, it is becoming clear that the side panel and related features will be implemented in JLab console window. That is to say, the console window
transient_display_data
(thetransient_message
plugin)It is hard to say which interface is better but the console window has the advantage of saving all histories, which will fix #143 because the output of the preview magic will not overwrite the error message from previous statement.
The text was updated successfully, but these errors were encountered: